feat(build_fpc): proposing the following modifications to the script v - #157
Open
megapixel-code wants to merge 1 commit into
Open
feat(build_fpc): proposing the following modifications to the script v#157megapixel-code wants to merge 1 commit into
megapixel-code wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
- Listen to the env variable FPC_CFG - use !/usr/bin/env bash instead of !/bin/bash in the shebang (not very important)
megapixel-code
commented
Jul 27, 2026
Comment thread
src/build_fpc.sh
| #============================================================================= | ||
|
|
||
| # Global: will be set by detect_fpc | ||
| FPC_CFG="" |
Copy link
Copy Markdown
Author
There was a problem hiding this comment.
Not needed because bash default value is an empty string
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am trying to package this program to NixPkgs. To be able to do so I need to be able to set a custom path for the FPC_CFG variable. fpc.cfg is not located in the same directory as the fpc program in nix.
also the use of the shebang !/usr/bin/env bash is preferable to !/bin/bash because not all UNIX system have a /bin/bash (nixos doesnt have it for example).
this is not very important for me as i can just ignore the shebang by executing the program like bash ./src/build_fpc.sh