FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

templates: add optional Series ID buttons to the patch list by rossburton · Pull Request #571 · getpatchwork/patchwork · GitHub

/ patchwork Public

templates: add optional Series ID buttons to the patch list - #571

Open
rossburton wants to merge 1 commit into
getpatchwork:mainfrom
rossburton:patchlist-copy
ConversationCommits (1)ChecksFiles changed
Open

templates: add optional Series ID buttons to the patch list#571
rossburton wants to merge 1 commit into
getpatchwork:mainfrom
rossburton:patchlist-copy

Conversation

rossburton commented Nov 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

If the user has turned on display of patch IDs, add another column with the series IDs to the patch list template.

Note that I've not tested this in production because I've not yet setup a local instance...

rossburton commented Nov 22, 2023

Copy link
Copy Markdown
Contributor Author

Now tested!

Had to use a nbsp to stop "Series ID" wrapping and ruining the header alignment.

rossburton commented Nov 22, 2023

Copy link
Copy Markdown
Contributor Author

I'm torn on whether the column should just be called "ID" and let its position clarify what ID it refers to.

rossburton commented Nov 22, 2023

Copy link
Copy Markdown
Contributor Author

Maybe the ID column should just be removed, and the button inline with the patch or series name?

stephenfin commented Jan 23, 2024

Copy link
Copy Markdown
Member

I wonder if, rather than adding another column, we could add the <button> in the existing series column, before the subject? Every bit as clickable but we avoid adding yet more columns to the rather large table.

templates: add optional Series ID buttons to the patch list
d80dc15 
If the user has turned on display of patch IDs, add clickable series ID
buttons inline with the series name.

Signed-off-by: Ross Burton <ross.burton@arm.com>

rossburton commented Jan 25, 2024

Copy link
Copy Markdown
Contributor Author

Done.

Would it be sensible to merge the "Patch ID" and "Patch" columns too?

rossburton commented Jan 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The good thing about two columns is it forces the alignment...

rossburton commented Feb 3, 2024

Copy link
Copy Markdown
Contributor Author

Polite ping

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL