Add an extra style when no checks are present - #656
Open
mchehab wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
For an example about its usecase, see: https://patchwork.linuxtv.org/project/linux-media/list/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Can you fix the pep8 issue? You should be able to just run tox -e pep8 / pre-commit run -a. |
Sorry, something went wrong.
On projects where all patches are meant to be checked, not having any checks mean that either the CI is still running or that CI didn't run for an specific patch. At the first case, the maintainers need to be aware to wait for CI to run; at the last case, if it takes too long, they may need to manually re-run CI or double-check resuls. Anyway, this is a sort of "error" status, so allow CSS to be able to customize it, by adding a "nochecks" state-like CSS style. Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Copy link
Copy Markdown
Contributor
Author
Done. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On projects where all patches are meant to be checked, not having any checks mean that either the CI is still running or that CI didn't run for an specific patch.
At the first case, the maintainers need to be aware to wait for CI to run; at the last case, if it takes too long, they may need to manually re-run CI or double-check resuls.
Anyway, this is a sort of "error" status, so allow CSS to be able to customize it, by adding a "nochecks" state-like CSS style.