Add autoUploadSourceContextBuildTypes property - #680
Draft
markushi wants to merge 1 commit into
Draft
markushi wants to merge 1 commit into
markushi wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Instructions and example for changelogPlease add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number. Example: ## Unreleased
- Add autoUploadSourceContextBuildTypes property ([#680](https://github.com/getsentry/sentry-android-gradle-plugin/pull/680))If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description. |
Sorry, something went wrong.
markushi
commented
Mar 26, 2024
Comment thread
plugin-build/src/main/kotlin/io/sentry/android/gradle/extensions/SentryPluginExtension.kt
| * Which build types should be considered for automatic source context upload. | ||
| * Default is "release" only. | ||
| */ | ||
| val autoUploadSourceContextBuildTypes: SetProperty<String> = objects |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
I'm not really sure if we should limit ourselves to build types, should add support for flavors too?
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Fixes #661
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
🔮 Next steps