fix(profiling): Reset shouldStop flag on startProfiler - #5284
Open
43jay wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Instructions and example for changelogPlease add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number. Example: ## Unreleased
### Fixes
- Reset shouldStop flag on startProfiler ([#5284](https://github.com/getsentry/sentry-java/pull/5284))If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label. |
Sorry, something went wrong.
43jay
marked this pull request as ready for review
April 10, 2026 16:24
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Performance metrics 🚀
Baseline results on branch: mainStartup times
App size
Previous results on branch: fix/profiling-shouldstop-resetStartup times
App size
|
Sorry, something went wrong.
…artProfiler Same fix as PerfettoContinuousProfiler — shouldStop was never reset to false after stopProfiler, so a stop/start cycle would leave shouldStop=true and silently stop the profiler after one chunk. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
43jay
force-pushed
the
fix/profiling-shouldstop-reset
branch
from
a9847ae to
5a599a2
Compare
April 13, 2026 20:04
romtsn
approved these changes
Apr 14, 2026
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
nice catch! please, add a changelog entry as well
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
shouldStop is never reset to false after stopProfiler(), so a stop/start cycle leaves shouldStop=true. When the next 60-second chunk timer fires, stop(restartProfiler=true) checks !shouldStop and does not restart — the profiler silently stops after one chunk instead of continuing indefinitely.
This affects both lifecycle modes:
Fix: reset shouldStop = false at the top of startProfiler(), since it represents a new intent to profile.
💡 Motivation and Context
Discovered while working on the Perfetto ProfilingManager integration (#5251). The same bug existed in both AndroidContinuousProfiler and PerfettoContinuousProfiler.
💚 How did you test it?
Unit test added: manual profiler can be started again after a full start-stop cycle — starts profiling, stops it, starts again, verifies the profiler continues running after the first chunk restart.
📝 Checklist
🔮 Next steps
None — standalone bugfix.