perf(android): Avoid exception-driven control flow in getResourceId - #5631
Merged
runningcode merged 2 commits intoJun 30, 2026
Merged
perf(android): Avoid exception-driven control flow in getResourceId#5631runningcode merged 2 commits into
runningcode merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
runningcode
marked this pull request as ready for review
June 25, 2026 11:11
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
June 25, 2026 11:11
0xadam-brown
approved these changes
Jun 26, 2026
0xadam-brown
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Always a win! One optional nit if you want it 💯
Sorry, something went wrong.
Comment thread
sentry-android-core/src/main/java/io/sentry/android/core/internal/gestures/ViewUtils.java
Outdated
runningcode
force-pushed
the
no/perf-android-resource-id-exceptions
branch
2 times, most recently
from
eeff1d6 to
9f7943e
Compare
June 26, 2026 09:54
Copy link
Copy Markdown
Contributor
Performance metrics 🚀
Baseline results on branch: mainStartup times
App size
Previous results on branch: no/perf-android-resource-id-exceptionsStartup times
App size
|
Sorry, something went wrong.
runningcode
force-pushed
the
no/perf-android-resource-id-exceptions
branch
from
9f7943e to
e484785
Compare
June 26, 2026 10:04
romtsn
approved these changes
Jun 26, 2026
romtsn
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
very nice!
Sorry, something went wrong.
ViewUtils.getResourceId threw Resources.NotFoundException for views with no id or a generated id, and callers caught and discarded it. During a view-hierarchy snapshot and on every gesture this ran per view, so in Compose-heavy apps where most views have generated ids the SDK constructed an exception (and a native stack trace fill) per view on the main thread. Add a non-throwing resolveResourceId that returns null for unresolved ids and route the hot callers through it. The public getResourceId remains as a throwing wrapper for backward compatibility. Behavior (emitted identifiers and fallbacks) is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
runningcode
force-pushed
the
no/perf-android-resource-id-exceptions
branch
from
e484785 to
81b9fcd
Compare
June 30, 2026 09:35
runningcode
enabled auto-merge (squash)
June 30, 2026 09:35
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JAVA-586
📜 Description
ViewUtils.getResourceId used exception-driven control flow: it threw Resources.NotFoundException for views with View.NO_ID or a generated id, and every caller caught and discarded it. This ran per view during view-hierarchy snapshots and gesture target resolution, so in Compose-heavy apps — where most views have generated ids — the SDK constructed an exception (and a native fillInStackTrace stack walk) for nearly every view, on the main thread.
This adds a non-throwing ViewUtils.resolveResourceId(View) that returns null for unresolved ids, and routes the hot callers (ViewHierarchyEventProcessor.viewToNode, AndroidViewGestureTargetLocator.createUiElement, getResourceIdWithFallback) through it. The public getResourceId(...) throws Resources.NotFoundException stays as a thin wrapper for backward compatibility. Emitted identifiers and fallbacks are unchanged.
💡 Motivation and Context
Found while analyzing a customer-provided Perfetto trace: in a single view-hierarchy snapshot, 24 of 72 getResourceId calls threw Resources.NotFoundException on the main thread — pure overhead with no functional result.
💚 How did you test it?
Unit tests in ViewUtilsTest cover the new resolveResourceId (generated id, NO_ID, resource-not-found, and success) plus the existing getResourceId/fallback behavior; ViewHierarchyEventProcessorTest and AndroidViewGestureTargetLocatorTest pass unchanged.
On-device A/B on a Pixel 3 (Android 12) via ART method tracing, analyzed in Perfetto trace_processor, over 2048 calls on NO_ID views:
Exactly one exception (+ native stack fill) per unresolved view is removed; ~60% fewer executed methods and ~4.7× cheaper per unresolved view (the absolute ns is inflated by tracing; the call counts and ratio are the reliable signal).
📝 Checklist
🔮 Next steps
Follow-ups identified in the same trace but intentionally out of scope here: per-touch LinkedList→ArrayDeque in ViewUtils.findTarget, and background JSON serialization cost.