| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Co-Authored-By: Gino Buenaflor <giancarlo.buenaflor@sentry.io>
|
Sorry, something went wrong.
📲 Install BuildsAndroid
|
Sorry, something went wrong.
Co-Authored-By: Gino Buenaflor <giancarlo.buenaflor@sentry.io>
Performance metrics 🚀
Baseline results on branch: mainStartup times
App size
Previous results on branch: feat/replay-segment-namesStartup times
App size
|
Sorry, something went wrong.
Co-Authored-By: Gino Buenaflor <giancarlo.buenaflor@sentry.io>
There was a problem hiding this comment.
Adds support for recording segment names (transaction names) in Session Replay so replay events can be queried by the named segment(s) that occurred during each replay segment.
Changes:
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| sentry/src/test/resources/json/sentry_replay_event.json | Updates replay event golden JSON to include segment_names. |
| sentry/src/test/java/io/sentry/SentryClientTest.kt | Adds/updates tests to verify segment name registration via ReplayController. |
| sentry/src/test/java/io/sentry/protocol/SentryReplayEventSerializationTest.kt | Ensures replay event protocol round-trip includes segmentNames. |
| sentry/src/main/java/io/sentry/SentryReplayEvent.java | Adds segmentNames field with JSON key segment_names plus (de)serialization and equality updates. |
| sentry/src/main/java/io/sentry/SentryClient.java | Registers captured transaction name with replay controller when a transaction is successfully sent. |
| sentry/src/main/java/io/sentry/ReplayController.java | Adds new internal API hook registerSegmentName. |
| sentry/src/main/java/io/sentry/NoOpReplayController.java | Implements the new no-op registerSegmentName method. |
| sentry/api/sentry.api | Updates public API dump for ReplayController, NoOpReplayController, and SentryReplayEvent. |
| sentry-android-replay/src/test/java/io/sentry/android/replay/capture/SessionCaptureStrategyTest.kt | Adds tests for deduplication, limit, and per-segment clearing of segment names. |
| sentry-android-replay/src/main/java/io/sentry/android/replay/ReplayIntegration.kt | Forwards registerSegmentName to the active capture strategy when recording. |
| sentry-android-replay/src/main/java/io/sentry/android/replay/capture/CaptureStrategy.kt | Extends internal replay segment creation flow to include segmentNames. |
| sentry-android-replay/src/main/java/io/sentry/android/replay/capture/BaseCaptureStrategy.kt | Implements collection/dedup/limit/clear logic for segment names alongside trace IDs. |
| sentry-android-replay/api/sentry-android-replay.api | Updates Android replay module API dump for ReplayIntegration. |
| CHANGELOG.md | Adds an unreleased changelog entry for the new replay segment name capability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Record transaction segment names on replay events so replays can be queried by the named transaction that occurred during each segment.
This is needed in Sentry Flutter to report segment names that occurred during replays. (getsentry/sentry-dart#3865)
Replay context
Adds ReplayController.registerSegmentName, collects unique names alongside trace IDs with the same 100-value limit, and clears both collections when a replay segment is created. Successfully captured native transactions register their transaction name automatically.
Payload
Replay events now serialize and deserialize the collected names as segment_names, with coverage for protocol round trips, deduplication, limits, and per-segment clearing.
Related work in Sentry Javascript getsentry/sentry-javascript#21851
Requested by Gino Buenaflor via Junior.
--
View Junior Session in Sentry