perf: Share one executor between log and metrics batch processors (JAVA-653) - #5818
Closed
runningcode wants to merge 2 commits into
Closed
perf: Share one executor between log and metrics batch processors (JAVA-653)#5818runningcode wants to merge 2 commits into
runningcode wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
This was referenced Jul 22, 2026
Copy link
Copy Markdown
Contributor
Performance metrics 🚀
Baseline results on branch: mainStartup times
App size
|
Sorry, something went wrong.
…VA-653) The log and metrics batch processors each created their own SentryExecutorService, so an app using both spawned two threads for work that is identical in shape (a 5s flush loop that hands envelopes to the transport). SentryClient now owns a single executor, created only when logs or metrics are enabled, and injects it into both processors via the default factories. The restart shutdown path tolerates the shared executor already being closed by the sibling processor. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
runningcode
force-pushed
the
no/perf/share-batch-processor-executor
branch
from
bb143cc to
875b0ea
Compare
July 22, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
LoggerBatchProcessor and MetricsBatchProcessor each constructed their own SentryExecutorService, so an app with both logs and metrics enabled ran two dedicated threads for structurally identical work (a 5-second flush loop that batches events and hands them to the transport).
SentryClient now owns a single SentryExecutorService, created only when logs or metrics are enabled, and exposes it via getBatchProcessorExecutorService(). The default factories inject it into both processors (through the existing 3-arg LoggerBatchProcessor constructor and a new matching one on MetricsBatchProcessor). The pluggable factory interfaces are unchanged.
The shutdown paths already close the executor from each processor's close(); since the executor is now shared, the second close is a safe no-op, and the restart branch's submit(...) is guarded with the same RejectedExecutionException fallback already used in Scopes.close() for the main executor.
💡 Motivation and Context
Part of reducing the number of threads created by the SDK: JAVA-653.
Saves one thread for every app that has both logs and metrics enabled. The executor is created only when at least one of logs or metrics is enabled, and its worker thread is spawned only when the first flush is scheduled.
Note for reviewers
Custom ILoggerBatchProcessorFactory / IMetricsBatchProcessorFactory implementations that call the public 2-arg processor constructors still get an independent executor (unchanged behavior). Only the default factories opt into the shared one.
💚 How did you test it?
New SentryClientTest case asserting both processors receive the same executor instance (and that it is the client's shared one), plus the existing LoggerBatchProcessorTest, MetricsBatchProcessorTest, SentryClientTest, LoggerApiTest, and MetricsApiTest suites.
📝 Checklist
🔮 Next steps
Related PRs in this effort: RateLimiter (#5814), LifecycleWatcher (#5819), performance collector (#5816), HostnameCache (#5817).
🤖 Generated with Claude Code