perf(core): Read the clock once per performance collection round - #5934
Merged
runningcode merged 2 commits intoAug 12, 2026
Merged
perf(core): Read the clock once per performance collection round#5934runningcode merged 2 commits into
runningcode merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
While a transaction is running, performance data is collected every 100ms. CompositeData.addDataAndCheckTimeout read the clock to check for the 30 second collection timeout once per in-flight transaction, allocating a SentryNanotimeDate each time, even though the enclosing timer task had just read it for the sample it was distributing. Pass that reading in, so a collection round reads the clock once instead of once per transaction.
8 tasks
runningcode
force-pushed
the
no/perf-collection-timeout-clock-reads
branch
from
a1eced1 to
22cbb55
Compare
August 11, 2026 13:46
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
runningcode
marked this pull request as ready for review
August 11, 2026 13:50
runningcode
requested review from
0xadam-brown,
adinauer,
markushi and
romtsn
as code owners
August 11, 2026 13:50
Copy link
Copy Markdown
Contributor
Performance metrics 🚀
Baseline results on branch: mainStartup times
App size
|
Sorry, something went wrong.
romtsn
approved these changes
Aug 11, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
While a transaction is running, DefaultCompositePerformanceCollector collects performance data every 100ms for up to 30 seconds.
CompositeData.addDataAndCheckTimeout read the clock to check the 30s collection timeout once per in-flight transaction, allocating a SentryNanotimeDate (plus System.currentTimeMillis() + System.nanoTime()) each time — even though the enclosing timer task had just read the same clock for the sample it was distributing.
That reading is now passed in, so a collection round reads the clock once rather than once per transaction.
💡 Motivation and Context
Perf improvement!
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps