perf(android): Use generated manifest metadata - #5969
Closed
romtsn wants to merge 5 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Allow the Android Gradle plugin to provide authoritative manifest metadata so SDK initialization can skip PackageManager and Bundle unparceling. Read the injected map directly to avoid conversion overhead. Refs JAVA-531 Co-Authored-By: Codex <noreply@openai.com>
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Performance metrics 🚀
Baseline results on branch: mainStartup times
App size
Previous results on branch: perf/java-531-generated-manifest-metadataStartup times
App size
|
Sorry, something went wrong.
…ed-manifest-metadata # Conflicts: # CHANGELOG.md
runningcode
reviewed
Aug 14, 2026
Comment thread
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Outdated
Use ManifestMetadataReader directly as the Gradle plugin injection target and remove the dedicated holder class. Co-Authored-By: OpenAI Codex <noreply@openai.com>
romtsn
force-pushed
the
perf/java-531-generated-manifest-metadata
branch
from
889ddc4 to
ef70a24
Compare
August 17, 2026 08:17
romtsn
marked this pull request as ready for review
August 17, 2026 10:18
romtsn
requested review from
0xadam-brown,
adinauer and
markushi
as code owners
August 17, 2026 10:18
runningcode
approved these changes
Aug 17, 2026
runningcode
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM from the sentry-java side. i just had one thought but not sure how feasible it is.
Sorry, something went wrong.
runningcode
approved these changes
Aug 17, 2026
runningcode
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM from the sentry-java side. i just had one thought but not sure how feasible it is.
Sorry, something went wrong.
Remove the device-specific benchmark percentage from the release note. Co-Authored-By: Codex <noreply@openai.com>
romtsn
enabled auto-merge (squash)
August 17, 2026 12:58
romtsn
disabled auto-merge
August 17, 2026 13:34
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Use manifest metadata injected by the Sentry Android Gradle plugin when available. The existing PackageManager Bundle remains the fallback, and all existing runtime option precedence remains unchanged.
💡 Motivation and Context
Reading ApplicationInfo metadata and converting every manifest option during startup showed up prominently in customer traces. The paired plugin change in getsentry/sentry-android-gradle-plugin#1405 resolves typed metadata from the final merged manifest and avoids that runtime work, reducing median SDK initialization time by 6.5% in the all-options benchmark.
💚 How did you test it?
Ran the ManifestMetadataReader release unit tests, including typed generated values, absent keys, auto-init, PackageManager fallback, and no Context access on the generated path. Also ran spotlessApply and apiDump.
📝 Checklist
🔮 Next steps
Release with getsentry/sentry-android-gradle-plugin#1405 to enable the generated path.