fix(android): Block profiling on unsupported system package - #5975
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
fix(android): Block profiling on unsupported system package#5975sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Co-Authored-By: Markus Hintersteiner <markus.hintersteiner@sentry.io>
Copy link
Copy Markdown
Contributor
Instructions and example for changelogPlease add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number. Example: ## Unreleased
### Fixes
- Block profiling on unsupported system package ([#5975](https://github.com/getsentry/sentry-java/pull/5975))If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label. |
Sorry, something went wrong.
Copy link
Copy Markdown
📲 Install BuildsAndroid
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Performance metrics 🚀
Baseline results on branch: mainStartup times
App size
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android system package version 370546200 can accept profiling requests but produce empty traces. This change resolves the installed profiling package version when the profiler is created and skips profiling for that version.
Unknown and other package versions keep the existing behavior.
Tests
Requested by markus.hintersteiner.
--
View Junior Session [Sentry]