| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Sorry, something went wrong.
📲 Install BuildsAndroid
|
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, just some nits
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
📜 Description
Makes the time window used to merge a tombstone with a native crash event configurable. NativeEventCollector had a hardcoded TIMESTAMP_TOLERANCE_MS = 5000; it now reads SentryAndroidOptions.getTombstoneMergeTimeThresholdMillis(), which keeps 5000 ms as its default, so behavior does not change unless the option is set.
The matching code also logs the threshold together with the measured gap, and logs when no native event was inside the window, so a failed merge can be diagnosed from a debug log.
💡 Motivation and Context
A user reported that native crashes still arrive as signalhandler events with a thin native stack instead of TombstoneMerged. The gap between the tombstone timestamp and the native crash envelope was 5.786 s, just above the fixed 5 s window, so the two were never paired. There was no way to raise the window.
💚 How did you test it?
Unit tests in sentry-android-core:
📝 Checklist
🔮 Next steps
The option is Android only, like the other tombstone options, so it is not wired into ExternalOptions (sentry.properties) or Spring Boot properties. Documentation for the new option can follow if the team wants it published.
🤖 Generated with Claude Code