| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Disable profiling when profilesSampler throws instead of applying the static profilesSampleRate or inheriting a parent profiling decision. Preserve trace sampling metadata and normal null-result fallback. Cover static-rate bypass, parent inheritance, and failures in both samplers without changing existing catch types. Refs #6081 Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
PR Stack (Callback Errors)
📜 Description
Disable profiling when profilesSampler throws, without changing trace sampling. Skip the configured profilesSampleRate and do not inherit a parent's profiling decision after callback failure.
The parent path preserves the trace sampling decision, trace sample rate, and sample-random value, including backfilling when needed. It does not mutate the original parent decision. A callback deliberately returning null still uses the existing fallback behavior. Error logging and catch types are unchanged.
If tracesSampler also throws, the failure behavior from #6163 disables both tracing and profiling regardless of the parent's decision. Its immediate callback_error reports and accepted duplicate sampling-loss reports remain unchanged.
💡 Motivation and Context
A failed profiling callback must not enable profiling through a static rate or parent inheritance. Returning the parent's entire sampling decision would bypass the local failure result and could re-enable profiling, so the failure path retains only the parent's trace fields.
💚 How did you test it?
📝 Checklist
🔮 Next steps
Profile discard accounting is handled separately in #6166. Profile/replay artifact cleanup remains a follow-up. The broader callback-boundary catch-type changes remain deferred to the next major.