feat(node): [v7] Support Node 22 - #11754
Merged
JonasBa merged 7 commits intoMay 1, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
AbhiPrasad
force-pushed
the
abhi-node-22
branch
from
37310a3 to
e0d8bb4
Compare
April 24, 2024 18:44
AbhiPrasad
requested review from
a team,
JonasBa,
anonrig,
lforst and
mydea
and removed request for
a team
April 24, 2024 18:45
AbhiPrasad
marked this pull request as ready for review
April 24, 2024 18:45
anonrig
approved these changes
Apr 24, 2024
JonasBa
approved these changes
Apr 24, 2024
Copy link
Copy Markdown
Contributor
Author
|
I guess the node 22 docker containers have not been published yet 😅 - so we have to wait for that too |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
You are just too fast @AbhiPrasad 🫣 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I'm taking matters into my own hands - nodejs/docker-node#2071 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
size-limit report 📦
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
blocked on docker-library/official-images#16663 |
Sorry, something went wrong.
Closed
Copy link
Copy Markdown
Contributor
Author
|
Docker stuff is released https://hub.docker.com/_/node/tags but late in day so we can only prob do v7 release on monday |
Sorry, something went wrong.
Closed
Copy link
Copy Markdown
Contributor
Author
Execute installation script
Check if Python hostedtoolcache folder exist...
Create Python 3.8.10 folder
Copy Python binaries to hostedtoolcache folder
Create additional symlinks (Required for the UsePythonVersion Azure Pipelines task and the setup-python GitHub Action)
Upgrading pip...
Looking in links: /tmp/tmp3o8h6q9d
Requirement already satisfied: setuptools in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (56.0.0)
Requirement already satisfied: pip in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (21.1.1)
Error: Usage:
/opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <requirement specifier> [package-index-options] ...
/opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] -r <requirements file> [package-index-options] ...
/opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <vcs project url> ...
/opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <local project path> ...
/opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <archive url/path> ...
no such option: --root-user-action
Error: The process '/usr/bin/bash' failed with exit code 2
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Setup python
bruh |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Oh wait this is happening on master as well! https://github.com/getsentry/sentry-javascript/actions/runs/8853059168/job/24313364936 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Here's the bug actions/setup-python#853 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Just need to fix a bug with win22, I'm hoping its an issue with the minmax macro |
Sorry, something went wrong.
JonasBa
approved these changes
May 1, 2024
s1gr1d
pushed a commit
that referenced
this pull request
May 2, 2024
tracking issue: #11455 ABI is 126: https://github.com/electron/node-abi/blob/bd11f2da07c5da324e735e2de5bf6716ce97b11c/abi_registry.json#L95-L102 ~Waiting for nodejs/node#52505 to release!~ Added changelog entry for `7.113.0`, will cut a release after this gets merged. --------- Co-authored-by: JonasBa <jonas@badalic.com>
s1gr1d
added a commit
that referenced
this pull request
May 2, 2024
Port from v7: #11754 --------- Co-authored-by: Abhijeet Prasad <aprasad@sentry.io> Co-authored-by: JonasBa <jonas@badalic.com>
This was referenced Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #11455
ABI is 126: https://github.com/electron/node-abi/blob/bd11f2da07c5da324e735e2de5bf6716ce97b11c/abi_registry.json#L95-L102
Waiting for nodejs/node#52505 to release!
Added changelog entry for 7.113.0, will cut a release after this gets merged.