Repository navigation
fix(sveltekit): Detect SvelteKit server build via Vite Environment API - #21629
Merged
chargome merged 4 commits intoJul 16, 2026
Merged
chargome merged 4 commits into
chargome merged 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
size-limit report 📦
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label PR: no-auto-close I will leave it alone ... forever! |
Sorry, something went wrong.
chargome
force-pushed
the
cg/kit-3-vite-detection
branch
from
06ac632 to
30c37ee
Compare
July 15, 2026 10:38
chargome
force-pushed
the
cg/kit-3-env-detection
branch
from
95c6732 to
af132f5
Compare
July 15, 2026 10:38
Copy link
Copy Markdown
Member
Author
|
bugbot run |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit af132f5. Configure here.
Sorry, something went wrong.
chargome
marked this pull request as ready for review
July 15, 2026 12:31
chargome
requested review from
mydea,
nicohrubec and
s1gr1d
and removed request for
a team
July 15, 2026 12:31
nicohrubec
approved these changes
Jul 15, 2026
…nfig SvelteKit 3.0.0-next.8 promoted the native server-tracing config out of `experimental` (`kit.experimental.tracing.server` -> `kit.tracing.server`). Read both locations when detecting native tracing so the SDK works across the supported peer range (SvelteKit 2.31+ and early Kit 3 prereleases keep it under `experimental`). Applies to detection from both the Vite plugin `api.options` and `svelte.config.js`, and covers both shapes in the unit tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
chargome
force-pushed
the
cg/kit-3-vite-detection
branch
from
30c37ee to
a2b8566
Compare
July 15, 2026 14:57
chargome
force-pushed
the
cg/kit-3-env-detection
branch
from
af132f5 to
7e22244
Compare
July 15, 2026 14:57
Comment thread
packages/sveltekit/src/vite/autoInstrument.ts
| // Prefer the environment of the current build (`this.environment.name === 'ssr'`) and fall back to | ||
| // `isServerBuild` for older Vite versions that don't expose environments. | ||
| const environmentName = (this as { environment?: { name?: string } }).environment?.name; | ||
| const isServerEnvironment = environmentName != null ? environmentName === 'ssr' : !!isServerBuild; |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Bug: The code hardcodes the server environment name as 'ssr'. This will fail for users who customize the environment name in Vite, leading to incorrect server-side instrumentation.
Severity: LOW
Avoid hardcoding the environment name 'ssr'. Instead, determine if the environment is server-side by a more robust method. For example, a more flexible check could be to consider any environment that is not explicitly the 'client' environment as a server-side one, which would accommodate custom names.
Prompt for AI AgentReview the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: packages/sveltekit/src/vite/autoInstrument.ts#L82 Potential issue: The logic at `autoInstrument.ts` assumes the Vite server environment is always named `'ssr'`. However, Vite's Environment API allows users to customize this name (e.g., to `'server'`). If a custom name is used and `onlyInstrumentClient` is `true`, the `isServerEnvironment` check will incorrectly evaluate to `false`. This causes server-side universal load functions to be instrumented when they should be skipped, resulting in incorrect stack frames for server-side errors in production for users with this specific configuration.
Did we get this right? 👍 / 👎 to inform future reviews.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is set by SvelteKit, right?
Sorry, something went wrong.
s1gr1d
approved these changes
Jul 16, 2026
Comment thread
packages/sveltekit/src/vite/autoInstrument.ts
| // Prefer the environment of the current build (`this.environment.name === 'ssr'`) and fall back to | ||
| // `isServerBuild` for older Vite versions that don't expose environments. | ||
| const environmentName = (this as { environment?: { name?: string } }).environment?.name; | ||
| const isServerEnvironment = environmentName != null ? environmentName === 'ssr' : !!isServerBuild; |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This is set by SvelteKit, right?
Sorry, something went wrong.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Lms24
approved these changes
Jul 16, 2026
49 tasks
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets the environment using this.environment.name and falls back to config.build.ssr for older Vite versions.
Un-skips the last remaining server-side error test in the Kit 3 e2e app.
ref #21502