feat(browser): Emit low cardinality resource span names - #23546
Open
logaretm wants to merge 2 commits into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
logaretm
force-pushed
the
awad/resource-span-names
branch
from
6b1501e to
6d54bef
Compare
August 24, 2026 17:45
logaretm
marked this pull request as ready for review
August 24, 2026 17:50
logaretm
requested review from
Lms24 and
msonnb
and removed request for
a team
August 24, 2026 17:51
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
size-limit report 📦
|
Sorry, something went wrong.
Names `resource.*` spans after the resource domain when span streaming is enabled, falling back to `Resource` when there is none. Also adds the `url.domain` attribute to these spans.
logaretm
force-pushed
the
awad/resource-span-names
branch
from
6d54bef to
cdc1a65
Compare
August 24, 2026 18:26
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cdc1a65. Configure here.
Sorry, something went wrong.
Comment thread
packages/browser-utils/src/performance/entries.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Names resource.* spans after the resource domain when span streaming is enabled, falling back to Resource when there's no domain.
The domain also lands on the span as url.domain in both lifecycles since it's just a missing attribute. Names in static mode are unchanged.
closes #23531