FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test(angular, ember): Cover router span name fallbacks by logaretm · Pull Request #23548 · getsentry/sentry-javascript · GitHub

test(angular, ember): Cover router span name fallbacks - #23548

Open
logaretm wants to merge 1 commit into
awad/js-3417-emit-low-cardinality-router-span-namesfrom
awad/js-3417-router-span-name-tests
Open

test(angular, ember): Cover router span name fallbacks#23548
logaretm wants to merge 1 commit into
awad/js-3417-emit-low-cardinality-router-span-namesfrom
awad/js-3417-router-span-name-tests

Conversation

logaretm commented Aug 24, 2026
edited
Loading

Copy link
Copy Markdown
Member

Covers the router span name fallback #23547 added, for the two SDKs it left untested.

linear-code Bot commented Aug 24, 2026

Copy link
Copy Markdown

JS-3417

logaretm force-pushed the awad/js-3417-router-span-name-tests branch 2 times, most recently from 3e2995c to 5ae2b30 Compare August 24, 2026 18:38
logaretm force-pushed the awad/js-3417-router-span-name-tests branch from 5ae2b30 to 623edef Compare August 24, 2026 18:44
Covers the router span name fallback end to end, not just at the unit
level. Both apps get a `sentryTest.variants` entry, which the e2e matrix
expands into a second matrix row that rebuilds the app with
`traceLifecycle: 'stream'` and runs the suite again.

Ember is built by Vite, so the lifecycle is a plain env var
(`VITE_TRACE_LIFECYCLE`). Angular can't read `process.env` in the browser
bundle, so it uses the builder's `fileReplacements` to swap
`trace-lifecycle.ts` for `trace-lifecycle.streamed.ts` under a new
`streamed` build configuration.

The assert command sets `E2E_TEST_TRACE_LIFECYCLE`, which the specs read:
the streamed specs skip unless it is set, and the transaction-based specs
skip when it is, since span streaming emits spans rather than
transactions.
logaretm force-pushed the awad/js-3417-router-span-name-tests branch from 623edef to 549f0db Compare August 24, 2026 18:44

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 28.57 kB - -
@sentry/browser - with treeshaking flags 26.92 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 26.82 kB - -
@sentry/browser (incl. Tracing) 48.34 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 48.36 kB - -
@sentry/browser (incl. Tracing, Profiling) 51.25 kB - -
@sentry/browser (incl. Tracing, Replay) 87.74 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 77.2 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 92.45 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 105.13 kB - -
@sentry/browser (incl. Feedback) 45.81 kB - -
@sentry/browser (incl. sendFeedback) 33.36 kB - -
@sentry/browser (incl. FeedbackAsync) 38.47 kB - -
@sentry/browser (incl. Metrics) 29.52 kB - -
@sentry/browser (incl. Logs) 29.8 kB - -
@sentry/browser (incl. Metrics & Logs) 30.45 kB - -
@sentry/react 30.33 kB - -
@sentry/react (incl. Tracing) 50.52 kB - -
@sentry/vue 35.4 kB - -
@sentry/vue (incl. Tracing) 50.32 kB - -
@sentry/svelte 28.6 kB - -
CDN Bundle 30.32 kB - -
CDN Bundle (incl. Tracing) 48.87 kB - -
CDN Bundle (incl. Logs, Metrics) 32.54 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 50.74 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 72.91 kB - -
CDN Bundle (incl. Tracing, Replay) 86.33 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 88.16 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 92.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 94 kB - -
CDN Bundle - uncompressed 89.94 kB - -
CDN Bundle (incl. Tracing) - uncompressed 146.13 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 96.23 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 151.81 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 225.18 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 265.4 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 271.07 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 279.09 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 284.76 kB - -
@sentry/nextjs (client) 53.06 kB - -
@sentry/sveltekit (client) 48.76 kB +0.02% +7 B 🔺
@sentry/core/server 64.97 kB +0.04% +20 B 🔺
@sentry/core/browser 52.11 kB - -
@sentry/node 117.55 kB +0.07% +81 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 85.18 kB - -
@sentry/node - without tracing 82.03 kB +0.03% +23 B 🔺
@sentry/aws-serverless 91.46 kB +0.03% +21 B 🔺
@sentry/cloudflare (withSentry) - minified 194.68 kB - -
@sentry/cloudflare (withSentry) 481.3 kB - -

View base workflow run

logaretm marked this pull request as ready for review August 24, 2026 19:37
logaretm requested review from a team, chargome and nicohrubec and removed request for a team August 24, 2026 19:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL