feat(vue): Register a route provider backed by the Vue router matcher - #23553
Draft
logaretm wants to merge 1 commit into
Draft
feat(vue): Register a route provider backed by the Vue router matcher#23553logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
14 tasks
Copy link
Copy Markdown
Contributor
size-limit report 📦
|
Sorry, something went wrong.
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
3232b67 to
09293e3
Compare
August 24, 2026 20:11
logaretm
force-pushed
the
awad/route-provider-vue
branch
2 times, most recently
from
2270fa1 to
0329f44
Compare
August 24, 2026 20:27
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
0329f44 to
b97883e
Compare
August 24, 2026 20:52
Labels routes through the same helper the navigation instrumentation uses, so a
route resolved by the provider can't disagree with the one on the span.
Handles both resolve shapes: Vue Router 3 returns `{ route }`, Vue Router 4+
returns the route itself.
logaretm
force-pushed
the
awad/route-provider-vue
branch
from
b97883e to
03f9074
Compare
August 24, 2026 20:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider backed by Vue Router's own matcher.
The label logic moves into a shared getRouteLabel that the provider and the existing navigation instrumentation both use, so a resolved route can't drift from the one on the span. Vue Router 3 resolves to { route } while 4+ returns the route directly, so the provider discriminates on matched.
Matcher-backed rather than fed from beforeEach, because beforeEach is registered after the pageload span is already created. Resolving against the router means Vue is one of the SDKs that can name its pageload span at creation once the consumers land, instead of renaming it after the fact.
Part of #23556