feat(tanstack): Register a route provider from the TanStack router matcher - #23554
Draft
logaretm wants to merge 1 commit into
Draft
feat(tanstack): Register a route provider from the TanStack router matcher#23554logaretm wants to merge 1 commit into
logaretm wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
14 tasks
Copy link
Copy Markdown
Contributor
size-limit report 📦
|
Sorry, something went wrong.
logaretm
force-pushed
the
awad/route-provider-tanstack
branch
from
eae10c7 to
dc3ca38
Compare
August 24, 2026 20:11
logaretm
force-pushed
the
awad/route-provider-tanstack
branch
from
dc3ca38 to
0291fba
Compare
August 24, 2026 20:17
logaretm
force-pushed
the
awad/route-provider-tanstack
branch
from
0291fba to
2c93abd
Compare
August 24, 2026 20:27
logaretm
force-pushed
the
awad/route-provider-tanstack
branch
from
2c93abd to
c4319f7
Compare
August 24, 2026 20:52
…tcher Hoists the existing `resolveRouteMatch` helper out of `afterAllSetup` in each of the three packages so the provider can reuse it, rather than restating the match rules. The matcher is already stateless, so nothing else had to change.
logaretm
force-pushed
the
awad/route-provider-tanstack
branch
from
c4319f7 to
ad1b053
Compare
August 24, 2026 20:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers a route provider from the TanStack Router matcher in the react, solid and vue packages.
resolveRouteMatch already existed in all three, just scoped inside afterAllSetup. Hoisting it lets the provider reuse it rather than restating the match rules.
Worth flagging: these three files are ~60% identical and have drifted. #23299 taught only the react copy to prefer router.state.location for the initial pageload match. Left alone here since it is a behavior fix that deserves its own PR.
Part of #23556