| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Sorry, something went wrong.
size-limit report 📦
|
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
| import { safeChannelCallback } from '../tracing-channel'; | ||
| import * as diagnosticsChannel from '../utils/diagnosticsChannel'; | ||
|
|
||
| interface ClassifierEvaluateChannelContext { |
There was a problem hiding this comment.
not specific to this PR, but I think we have an object that looks (almost) exactly like this in most or all of our integrations. we should probably refactor that at some point too
Sorry, something went wrong.
There was a problem hiding this comment.
Agreed, filed JS-3892 to add one shared orchestrion payload type.
Sorry, something went wrong.
| safeChannelCallback(() => { | ||
| const call = calls.get(message as object); | ||
| if (call) { | ||
| finishClassifierEvaluation(call, message as ClassifierEvaluateChannelContext); |
There was a problem hiding this comment.
m/h: it seems mastra default-configures some filters that run on span events, for instance a sensitive data filter: https://mastra.ai/reference/observability/tracing/processors/sensitive-data-filter
iiuc this message object that is copied to the outputs here is stored from the original input so these filters are probably not applied yet? I am concerned this could leak sensitive data
Sorry, something went wrong.
There was a problem hiding this comment.
Good catch. I ended up running their processors over the data before storing it in f12213b.
I was debating wether we should reconstruct the data at all, but figured we are in the o11y business and it makes sense to do so. I'll file an issue upstream.
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
There was a problem hiding this comment.
ja passt
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c3f2fa5. Configure here.
Sorry, something went wrong.
…ate spans Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
## What Adds a node-mastra e2e test that runs a real Jev evaluation through a Mastra `Classifier` (via OpenRouter) and checks the `gen_ai.evaluate` span. ## Why Covers the classifier instrumentation from #25044 against the real provider, not only a mock model.
| Back | FazBrowse Home | New Git URL |
What
Mastra classifier evaluations (Jev calls through Mastra's Classifier, its processors and scorers) now show up as gen_ai.evaluate spans with model, provider and token usage. When gen_ai recording is on, they also record the evaluated state, questions and answers.
Why
These calls skip the AI SDK hook, and our Mastra exporter dropped their spans, so they were invisible.
Closes: #25031