Repository navigation
fix(sveltekit): Upload source maps with SvelteKit 3 - #25139
Draft
chargome wants to merge 1 commit into
Draft
chargome wants to merge 1 commit into
chargome wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
SvelteKit 3 builds all environments in one Vite build and invokes the adapter in a post buildApp hook, so the closeBundle upload never ran. Upload from a post buildApp hook as well, once an environment has been built. Source maps were also never deleted after upload, because the deletion check read build.sourcemap after our own plugin had already set it. Fixes #25096 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
bugbot run |
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 424ee8f. Configure here.
Sorry, something went wrong.
Comment thread
packages/sveltekit/src/vite/sourceMaps.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
Assignees
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SvelteKit 3 builds all environments in a single Vite build and runs the adapter in a post buildApp hook. Our upload waited for a separate SSR build in closeBundle, which Kit 3 never does, so nothing was uploaded. We now also upload from a post buildApp hook, but only once an environment has been built. Kit 2 builds only after all buildApp hooks have run, so its closeBundle path still does the upload.
Source maps were also never deleted after upload, on Kit 2 or Kit 3. The deletion check read build.sourcemap after our own plugin had already set it.
The new sveltekit-3-sourcemaps e2e app builds against a mock Sentry server. It asserts that the upload happens, that every debug ID has a map, and that no maps are left in build/.
Fixes #25096