| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Page loads started a new trace. The middleware now adds `sentry-trace` and `baggage` entries to the `Server-Timing` header of HTML responses, ahead of the route entry, the way the Remix 2 SDK and Nitro do. The browser SDK already reads them off the navigation timing entry for page loads, so no client change. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
bugbot run |
Sorry, something went wrong.
Sorry, something went wrong.
size-limit report 📦
|
Sorry, something went wrong.
|
bugbot run |
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
|
bugbot run |
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
A shared cache would hand one request's trace to every later page load of the cached document. A response with `public`, `s-maxage` or a positive `max-age` and no `private`/`no-store` carries the route entry only, which is the same for every request to it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
bugbot run |
Sorry, something went wrong.
…test Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
bugbot run |
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
|
bugbot run |
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
Without a lifetime in `Cache-Control`, a cache falls back to `Expires`, so a response with only a future `Expires` could still hand its trace to later page loads. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
bugbot run |
Sorry, something went wrong.
There was a problem hiding this comment.
Stale Bugbot comment from a previous run.
Sorry, something went wrong.
…guard A zero lifetime with `stale-while-revalidate` or `stale-if-error` is still served stale by a shared cache. A CDN reads `CDN-Cache-Control`, its vendor variants or `Surrogate-Control` instead of `Cache-Control`, so a document can be cacheable at the CDN while private to the browser. Any source that lets a shared cache reuse the response keeps the trace off it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
bugbot run |
Sorry, something went wrong.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 645c9dd. Configure here.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Browser page loads in Remix 3 started a new trace. The server middleware now adds sentry-trace and baggage entries to the Server-Timing header of HTML responses, ahead of the route entry, the same channel the Remix 2 SDK and Nitro use. The browser SDK already reads both off the navigation timing entry for page loads, so no client change is needed.
A response a shared cache may store (public, s-maxage, or a positive max-age without private/no-store) carries the route entry only: a cached document would otherwise hand one request's trace to every later page load, the ISR problem the Next.js SDK works around on the client.
The e2e test asserts that the page load span shares the server span's trace id and has it as parent.
Fixes #25137