feat(pii): add data collection options - #2147
Closed
Litarnus wants to merge 9 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
src/Options.php
Outdated
Comment thread
src/Options.php
Outdated
Comment thread
src/DataCollection/DataCollectionOptions.php
Outdated
Comment thread
src/DataCollection/DataCollectionOptionsNormalizer.php
Outdated
Comment thread
src/DataCollection/DataCollectionOptions.php
Outdated
Comment thread
src/DataCollection/HttpHeaders.php
Comment thread
src/DataCollection/HttpHeaders.php
Outdated
Comment thread
src/DataCollection/DataCollectionOptions.php
Outdated
Comment thread
src/DataCollection/DataCollectionOptions.php
Outdated
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ab460c6. Configure here.
Sorry, something went wrong.
Comment thread
src/DataCollection/HttpHeaders.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the configuration structure necessary for data collection.
This is our first nested configuration and to be backwards compatible, it defines OptionsResolvers per layer.