Deprecates and changes enable_logs and enable_metrics to be effectively no-ops. The reason for this change is that those flags were basically just kill switches for the entire feature and disabled by default.
Users had to
add a log handler or call log functions directly and
enable the log feature to make sure they arrive.
Metrics are even more explicit since one has to invoke functions to emit metrics and we don't have any integrations.
Once this is merged, adding a handler or calling a log/metric function will be considered as a signal that this type of telemetry is wanted, and we will no longer respect the flag.
For anyone using those flags as kill switches: it's possible to implement kill switches using before_send_log and before_send_metric and return null in those callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates and changes enable_logs and enable_metrics to be effectively no-ops. The reason for this change is that those flags were basically just kill switches for the entire feature and disabled by default.
Users had to
Metrics are even more explicit since one has to invoke functions to emit metrics and we don't have any integrations.
Once this is merged, adding a handler or calling a log/metric function will be considered as a signal that this type of telemetry is wanted, and we will no longer respect the flag.
For anyone using those flags as kill switches: it's possible to implement kill switches using before_send_log and before_send_metric and return null in those callbacks.