feat(integrations): Add integration for `aiomysql` by tonal · Pull Request #4703 · getsentry/sentry-python · GitHub

Add support for aiomysql to the SDK.

Hey @tonal thanks for the PR, great work! Could you address the cursor comments above?

Thanks for the contribution, much appreciated!

Can you add unit tests for the integration as well? You can probably adapt them from the asyncpg tests.

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

Integrations

Add integration for aiomysql by tonal in #4703

Instrument pyreqwest tracing by servusdei2018 in #5682

Other

(ai) Redact base64 data URLs in image_url content blocks by ericapisani in #5953
(ci) Cancel in-progress PR workflows on new commit push by joshuarli in #5994
(litellm) Add async callbacks by alexander-alderman-webb in #5969

Bug Fixes 🐛

Anthropic

Capture exceptions for stream() calls by alexander-alderman-webb in #5950
Stop setting transaction status when child span fails by alexander-alderman-webb in #5717
Only finish relevant spans in .create() patches by alexander-alderman-webb in #5716

Pydantic Ai

Adapt import for new library versions by alexander-alderman-webb in #5984
Use first-class hooks when available by alexander-alderman-webb in #5947

Other

(huggingface_hub) Stop setting transaction status when a child span fails by Zenithatic in #5952
(litellm) Avoid double span exits when streaming by alexander-alderman-webb in #5933
(wsgi) Respect HTTP_X_FORWARDED_PROTO in request.url construction by sl0thentr0py in #5963

Internal Changes 🔧

Litellm

Replace mocks with httpx types in rate-limit test by alexander-alderman-webb in #5975
Replace mocks with httpx types in embedding tests by alexander-alderman-webb in #5970
Replace mocks with httpx types in nonstreaming completion() tests by alexander-alderman-webb in #5937
Remove dead attributes by alexander-alderman-webb in #5985

Other

(ai) Remove gen_ai.tool.type span attribute by ericapisani in #5964
(anthropic) Separate sync and async .create() patches by alexander-alderman-webb in #5715
(openai) Split token counting by API for easier deprecation by ericapisani in #5930
(openai-agents) Remove error attributes by alexander-alderman-webb in #5986
(opentelemetry) Ignore mypy error by alexander-alderman-webb in #5927
🤖 Update test matrix with new releases (04/13) by github-actions in #5983
Fix license metadata in setup.py by sl0thentr0py in #5934
Update validate-pr workflow by stephanie-anderson in #5931

Other

release: 2.58.0 by ericapisani in ce445d96
Handle None span context in the span processor and pin tokenizers version for anthropic tests on Python 3.8 by alexander-alderman-webb in #5967

🤖 This preview updates automatically when you update the PR.

Rewrite the aiomysql integration to fix issues raised in PR getsentry#4703: - Patch Cursor.execute and Cursor.executemany instead of Connection.query - Make _wrap_connect async (await inside span context) - Handle bytes/bytearray queries from executemany's internal batching - Normalize query text using " ".join(query.split()) for performance - Protect _sentry_skip_next_execute flag with try/finally to prevent leakage - Remove dead _wrap_cursor and unused _record context manager Add 17 end-to-end tests covering connect, execute, executemany, record_params, cursor iteration, connection pools, query source, span origin, and normalization. Update CI configuration: tox.ini envlist, GitHub Actions workflow with MySQL service container, and test suite config. Co-Authored-By: Qwen Code <noreply@anthropic.com> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Create _get_connect_data() to build breadcrumb dict directly from connection, instead of relying on span._data which is empty for NoOpSpan. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

CI problems have been resolved. Please merge master into your branch @tonal.
Can you also not include uv.lock or screenshot files in your PR. We cannot merge these.

- Add needs_mysql to services check - Add MySQL service container configuration - Add MySQL environment variables for tests

@cursor[bot] Regarding the "Nested executemany clears skip flag" issue:

After reviewing the aiomysql source code (aiomysql/cursors.py), I can confirm that executemany does NOT call itself recursively:

In the INSERT/REPLACE case, executemany calls _do_execute_many, which calls self.execute() (not self.executemany())
In the non-INSERT fallback case, executemany calls self.execute() in a loop (again, not self.executemany())

The nested executemany scenario described in the comment cannot occur with the actual aiomysql implementation. The current boolean flag approach works correctly for this use case.

This is a false positive - the theoretical issue doesn't apply to this integration.

The MySQL CI flag issue has been fixed.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7c952eb. Configure here.

- Use DB_SYSTEM_NAME instead of DB_SYSTEM for StreamedSpan - Use DB_NAMESPACE instead of DB_NAME for StreamedSpan - Add DB_DRIVER_NAME attribute for both StreamedSpan and regular Span - Follow asyncpg/sqlalchemy integration patterns

- Update _get_connect_data to accept use_streaming_keys flag - Use DB_SYSTEM_NAME and DB_NAMESPACE for streaming breadcrumbs - Create span_attributes by merging internal keys with breadcrumb_data - Breadcrumbs no longer contain internal Sentry keys (sentry.op, sentry.origin)

You'll have to merge master in again because of recent changes to our test matrix 😬.

Otherwise LGTM so I'll merge once that's done!

Co-authored-by: Anton Pirker <anton.pirker@sentry.io> Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

integration for aiomysql

878dc5b

tonal requested a review from a team as a code owner August 14, 2025 09:43

seer-by-sentry Bot reviewed Aug 14, 2025

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

seer-by-sentry Bot reviewed Aug 14, 2025

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

This comment was marked as outdated.

Sign in to view

tonal added 3 commits August 20, 2025 16:24

Drop _wrap_cursor_creation in integration aiomysql.py

29b4e85

Potential KeyError in _wrap_connect

28e79b6

Merge branch 'getsentry:master' into patch-2

950032f

This comment was marked as outdated.

Sign in to view

sentrivana linked an issue Aug 25, 2025 that may be closed by this pull request

'Span' object has no attribute '_context_manager_state' #4718

Closed

sentrivana removed a link to an issue Aug 25, 2025

'Span' object has no attribute '_context_manager_state' #4718

Closed

Merge branch 'master' into patch-2

421abfa

This comment was marked as outdated.

Sign in to view

antonpirker added the New Integration Integrating with a new framework or library label Sep 11, 2025

Merge branch 'master' into patch-2

ab35ef8

antonpirker changed the title integration for aiomysql Feat(integrations): Add integration for aiomysql Sep 11, 2025

antonpirker changed the title Feat(integrations): Add integration for aiomysql feat(integrations): Add integration for aiomysql Sep 11, 2025

Merge branch 'master' into patch-2

c09eb44

This comment was marked as outdated.

Sign in to view

alexander-alderman-webb reviewed Oct 9, 2025

View reviewed changes

tonal added 3 commits October 10, 2025 15:49

Merge branch 'master' into patch-2

b3b04a1

Merge branch 'master' into patch-2

d9d7282

Merge branch 'getsentry:master' into patch-2

faf1a87

sentry Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

cursor Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

sentry Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py

cursor Bot reviewed Apr 12, 2026

View reviewed changes

Comment thread scripts/split_tox_gh_actions/templates/test_group.jinja Outdated

Comment thread sentry_sdk/integrations/aiomysql.py

tonal and others added 2 commits May 22, 2026 18:29

Merge remote-tracking branch 'upstream/master' into patch-2

61ce6aa

Merge branch 'master' into patch-2

db77a50

sentry Bot reviewed May 22, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

cursor Bot reviewed May 22, 2026

View reviewed changes

Comment thread scripts/populate_tox/config.py Outdated

fix(aiomysql): Move config entry to alphabetical order

ddd200d

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

sentry Bot reviewed May 22, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py Outdated

fix(aiomysql): Populate breadcrumb data independently of span

43ca59d

Create _get_connect_data() to build breadcrumb dict directly from connection, instead of relying on span._data which is empty for NoOpSpan. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

tonal requested a review from alexander-alderman-webb May 23, 2026 14:37

tonal force-pushed the patch-2 branch 3 times, most recently from 825b197 to b688d52 Compare June 1, 2026 08:36

Merge upstream/master into patch-2

a1b709b

tonal force-pushed the patch-2 branch from b688d52 to a1b709b Compare June 1, 2026 08:38

cursor Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread scripts/split_tox_gh_actions/split_tox_gh_actions.py

Comment thread sentry_sdk/integrations/aiomysql.py

fix(ci): Add MySQL service container support to CI workflows

7c952eb

- Add needs_mysql to services check - Add MySQL service container configuration - Add MySQL environment variables for tests

cursor Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py

tonal force-pushed the patch-2 branch from 7c81fd6 to da6db01 Compare June 1, 2026 09:18

sentry Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/aiomysql.py

tonal added 2 commits June 2, 2026 22:14

Merge upstream/master into patch-2

e14f988

Merge upstream/master into patch-2

dad32a4

alexander-alderman-webb approved these changes Jun 3, 2026

View reviewed changes

alexander-alderman-webb merged commit 0527c03 into getsentry:master Jun 3, 2026
264 of 267 checks passed

sentry-release-bot Bot mentioned this pull request Jun 8, 2026

publish: getsentry/sentry-python@2.62.0 getsentry/publish#8470

Closed

6 tasks

alexander-alderman-webb mentioned this pull request Jun 8, 2026

feat: Add aiomysql integration page getsentry/sentry-docs#18298

Merged

6 tasks

+              """
+              Adapted from module sentry_sdk.integrations.asyncpg
+              """

feat(integrations): Add integration for `aiomysql` by tonal · Pull Request #4703 · getsentry/sentry-python · GitHub

Uh oh!

feat(integrations): Add integration for aiomysql - #4703

feat(integrations): Add integration for aiomysql#4703alexander-alderman-webb merged 42 commits intogetsentry:mastergetsentry/sentry-python:masterfrom tonal:patch-2tonal/sentry-python:patch-2Copy head branch name to clipboard

Conversation

tonal commented Aug 14, 2025 • edited by antonpirker Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

antonpirker commented Sep 11, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

alexander-alderman-webb Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Integrations

Other

Bug Fixes 🐛

Anthropic

Pydantic Ai

Other

Internal Changes 🔧

Litellm

Other

Other

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexander-alderman-webb commented May 26, 2026

Uh oh!

Uh oh!

Uh oh!

tonal commented Jun 1, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexander-alderman-webb commented Jun 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(integrations): Add integration for aiomysql#4703
alexander-alderman-webb merged 42 commits into
getsentry:masterfrom
tonal:patch-2

tonal commented Aug 14, 2025 •
edited by antonpirker
Loading

github-actions Bot commented Apr 12, 2026 •
edited
Loading