fix(clickhouse): Guard against module shadowing - #5250
Merged
alexander-alderman-webb merged 4 commits intoJan 9, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
alexander-alderman-webb
marked this pull request as draft
December 17, 2025 13:42
alexander-alderman-webb
marked this pull request as ready for review
December 18, 2025 08:45
alexander-alderman-webb
marked this pull request as draft
December 18, 2025 09:10
alexander-alderman-webb
marked this pull request as ready for review
December 18, 2025 09:47
sentrivana
approved these changes
Jan 8, 2026
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Probably quite unlikely that something as specific as clickhouse_driver would be shadowed, but doesn't hurt to be extra safe.
Sorry, something went wrong.
This was referenced Jan 9, 2026
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use explicit imports to prevent AttributeError when clickhouse_driver is shadowed.
Issues
Follows up on #5140.
Reminders