FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(typer): Guard against module shadowing by alexander-alderman-webb · Pull Request #5253 · getsentry/sentry-python · GitHub

/ sentry-python Public

fix(typer): Guard against module shadowing #5253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-alderman-webb merged 2 commits into from
Jan 9, 2026
Conversation 0 Commits 2 Checks 153 Files changed
Merged

fix(typer): Guard against module shadowing #5253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91de719
fix(typer): Guard against module shadowing
alexander-alderman-webb Dec 17, 2025
dd49ea0
merge master
alexander-alderman-webb Jan 9, 2026
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
3 changes: 2 additions & 1 deletion sentry_sdk/integrations/typer.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

try:
import typer
from typer.main import except_hook
except ImportError:
raise DidNotEnable("Typer not installed")

Expand All @@ -31,7 +32,7 @@ class TyperIntegration(Integration):

@staticmethod
def setup_once() -> None:
typer.main.except_hook = _make_excepthook(typer.main.except_hook) # type: ignore
typer.main.except_hook = _make_excepthook(except_hook) # type: ignore


def _make_excepthook(old_excepthook: "Excepthook") -> "Excepthook":
Expand Down
1 change: 0 additions & 1 deletion tests/test_shadowed_module.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ def pytest_generate_tests(metafunc):
- {
"litellm",
"ray",
"typer",
},
)

Expand Down
Loading
Back | FazBrowse Home | New Git URL