fix(anthropic): Close span on `GeneratorExit` by alexander-alderman-webb · Pull Request #5643 · getsentry/sentry-python · GitHub

Description

Run post-iterator steps in a finally block so they run even if the generator does not complete.

Issues

Reminders

Please add tests to validate your changes, and lint your code using tox -e linters.
Add GH Issue ID & Linear ID (if applicable)
PR title should use conventional commit style (feat:, fix:, ref:, meta:)
For external contributors: CONTRIBUTING.md, Sentry SDK development docs, Discord community

…med response

…ropic/only-raw-message-stream-events

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

New Features ✨

Anthropic

Set gen_ai.response.id span attribute by ericapisani in #5662
Add gen_ai.system attribute to spans by ericapisani in #5661

Pydantic Ai

Support ImageUrl content type in span instrumentation by ericapisani in #5629
Add tool description to execute_tool spans by ericapisani in #5596

Other

(crons) Add owner field to MonitorConfig by julwhitney13 in #5610
(otlp) Add collector_url option to OTLPIntegration by sl0thentr0py in #5603

Bug Fixes 🐛

(anthropic) Close span on GeneratorExit by alexander-alderman-webb in #5643

(celery) Propagate user-set headers by sentrivana in #5581
(utils) Avoid double serialization of strings in safe_serialize by ericapisani in #5587
Enable unused import ruff check and fix unused imports by sentrivana in #5652

Documentation 📚

(openai-agents) Remove inapplicable comment by alexander-alderman-webb in #5495
Add AGENTS.md by sentrivana in #5579
Add set_attribute example to changelog by sentrivana in #5578

Internal Changes 🔧

Anthropic

Skip accumulation logic for unexpected types in streamed response by alexander-alderman-webb in #5564
Factor out streamed result handling by alexander-alderman-webb in #5563
Stream valid JSON by alexander-alderman-webb in #5641
Stop mocking response iterator by alexander-alderman-webb in #5573

Docs

Remove agentic codebase documentation workflows by dingsdax in #5655
Switch agentic workflows from Copilot to Claude engine by dingsdax in #5654
Add agentic workflows for codebase documentation by dingsdax in #5649

Openai Agents

Do not fail on new tool fields by alexander-alderman-webb in #5625
Stop expecting a specific function name by alexander-alderman-webb in #5623
Set streaming header when library uses with_streaming_response() by alexander-alderman-webb in #5583
Replace mocks with httpx for streamed responses by alexander-alderman-webb in #5580
Replace mocks with httpx in non-MCP tool tests by alexander-alderman-webb in #5602
Replace mocks with httpx in MCP tool tests by alexander-alderman-webb in #5605
Replace mocks with httpx in handoff tests by alexander-alderman-webb in #5604
Replace mocks with httpx in API error test by alexander-alderman-webb in #5601
Replace mocks with httpx in non-error single-response tests by alexander-alderman-webb in #5600
Remove test for unreachable state by alexander-alderman-webb in #5584
Expect namespace tool field for new openai versions by alexander-alderman-webb in #5599

Other

(graphene) Simplify span creation by sentrivana in #5648
(httpx) Resolve type checking failures by alexander-alderman-webb in #5626
(pyramid) Support alpha suffixes in version parsing by alexander-alderman-webb in #5618
(rust) Don't implement separate scope management by sentrivana in #5639
(strawberry) Simplify span creation by sentrivana in #5647
Remove custom warden action by sentrivana in #5653
Add httpx to linting requirements by alexander-alderman-webb in #5644
Remove CodeQL action by sentrivana in #5616
Normalize dots in package names in populate_tox.py by alexander-alderman-webb in #5574
Do not run actions on potel-base by sentrivana in #5614

🤖 This preview updates automatically when you update the PR.

Codecov Results 📊

✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 4.75s

All tests are passing successfully.

❌ Patch coverage is 0.00%. Project has 14077 uncovered lines.

Files with missing lines (1)

File	Patch %	Lines
anthropic.py	8.47%	⚠️ 270 Missing

Generated by Codecov Action

…ropic/only-raw-message-stream-events

…b/anthropic/handle-generator-exit

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

alexander-alderman-webb added 25 commits February 27, 2026 10:51

ref(anthropic): Factor out streamed result handling

4cf7e5a

ref(anthropic): Skip accumulation logic for unexpected types in strea…

61a4cd0

…med response

.

6cdab16

.

db5dbb9

Merge branch 'webb/anthropic/separate-output-handling' into webb/anth…

091506c

…ropic/only-raw-message-stream-events

.

d47b64d

remove duplicate import

384351f

.

55d5c27

simplify

fd84837

.

53859e4

remove unused import

e2d6d78

add docstring

a01f7c1

add return

7837439

remove return statement

0e06f49

merge

c396a32

Merge branch 'master' into webb/anthropic/only-raw-message-stream-events

d4022c5

Merge branch 'master' into webb/anthropic/separate-output-handling

4e3d1db

Merge branch 'webb/anthropic/separate-output-handling' into webb/anth…

531c6a8

…ropic/only-raw-message-stream-events

.

917b8d4

.

aa6e58a

.

bd00e4e

merge

a6da66e

fix type

c988c26

Merge branch 'webb/anthropic/separate-output-handling' into webb/anth…

3009ba6

…ropic/only-raw-message-stream-events

fix(anthropic): Close span on GeneratorExit

9eff33e

revert conftest

5e3cb5f

github-actions Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/anthropic.py Outdated

Merge branch 'master' into webb/anthropic/separate-output-handling

ab5e3bb

alexander-alderman-webb added 2 commits March 12, 2026 09:41

Merge branch 'webb/anthropic/separate-output-handling' into webb/anth…

571db4e

…ropic/only-raw-message-stream-events

Merge branch 'webb/anthropic/only-raw-message-stream-events' into web…

804db65

…b/anthropic/handle-generator-exit

alexander-alderman-webb marked this pull request as ready for review March 12, 2026 09:25

alexander-alderman-webb requested a review from a team as a code owner March 12, 2026 09:25

sentry Bot reviewed Mar 12, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/anthropic.py Outdated

alexander-alderman-webb marked this pull request as draft March 12, 2026 09:51

alexander-alderman-webb marked this pull request as ready for review March 12, 2026 09:52

sentrivana approved these changes Mar 12, 2026

View reviewed changes

ericapisani approved these changes Mar 13, 2026

View reviewed changes

Base automatically changed from webb/anthropic/only-raw-message-stream-events to master March 13, 2026 13:52

alexander-alderman-webb added 2 commits March 13, 2026 14:55

merge master

2a0e5e9

keep comment

f36dd5d

cursor Bot reviewed Mar 13, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/anthropic.py Outdated

wrap finally in capture internal exceptions

0da2362

alexander-alderman-webb merged commit c84b6d8 into master Mar 13, 2026
158 checks passed

alexander-alderman-webb deleted the webb/anthropic/handle-generator-exit branch March 13, 2026 14:14

sentry-release-bot Bot mentioned this pull request Mar 17, 2026

publish: getsentry/sentry-python@2.55.0 getsentry/publish#7485

Closed

6 tasks

fix(anthropic): Close span on `GeneratorExit` by alexander-alderman-webb · Pull Request #5643 · getsentry/sentry-python · GitHub

Uh oh!

fix(anthropic): Close span on GeneratorExit - #5643

fix(anthropic): Close span on GeneratorExit#5643
alexander-alderman-webb merged 32 commits into
masterfrom
webb/anthropic/handle-generator-exit

alexander-alderman-webb commented Mar 12, 2026 •
edited
Loading

Uh oh!

Uh oh!

github-actions Bot commented Mar 12, 2026 •
edited
Loading

Uh oh!

Uh oh!

github-actions Bot commented Mar 12, 2026 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(anthropic): Close span on `GeneratorExit` by alexander-alderman-webb · Pull Request #5643 · getsentry/sentry-python · GitHub

Uh oh!

fix(anthropic): Close span on GeneratorExit - #5643

fix(anthropic): Close span on GeneratorExit#5643alexander-alderman-webb merged 32 commits intomastergetsentry/sentry-python:masterfrom webb/anthropic/handle-generator-exitgetsentry/sentry-python:webb/anthropic/handle-generator-exitCopy head branch name to clipboard

Conversation

alexander-alderman-webb commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Reminders

Uh oh!

github-actions Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

New Features ✨

Anthropic

Pydantic Ai

Other

Bug Fixes 🐛

Documentation 📚

Internal Changes 🔧

Anthropic

Docs

Openai Agents

Other

Uh oh!

github-actions Bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(anthropic): Close span on GeneratorExit#5643
alexander-alderman-webb merged 32 commits into
masterfrom
webb/anthropic/handle-generator-exit

alexander-alderman-webb commented Mar 12, 2026 •
edited
Loading

github-actions Bot commented Mar 12, 2026 •
edited
Loading

github-actions Bot commented Mar 12, 2026 •
edited
Loading