FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test(starlette): Verify request info capture with POST endpoints by alexander-alderman-webb · Pull Request #6269 · getsentry/sentry-python · GitHub

/ sentry-python Public

test(starlette): Verify request info capture with POST endpoints - #6269

Merged
alexander-alderman-webb merged 5 commits into
masterfrom
webb/starlette/request-extractor-tests
Jun 9, 2026
ConversationCommits (5)ChecksFiles changed
Merged

test(starlette): Verify request info capture with POST endpoints#6269
alexander-alderman-webb merged 5 commits into
masterfrom
webb/starlette/request-extractor-tests

Conversation

alexander-alderman-webb commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Replace tests that directly call StarletteRequestExtractor with tests that assert that request info is captured on errors and transaction events when appropriate POST endpoints are called.

Issues

Reminders

github-actions Bot commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 88732 passed | ⏭️ 6025 skipped | Total: 94757 | Pass Rate: 93.64% | Execution Time: 300m 29s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -44
Passed Tests 📉 -44
Failed Tests —
Skipped Tests —

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2355 uncovered lines.
✅ Project coverage is 89.9%. Comparing base (base) to head (head).

Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.90%    89.90%        —%
==========================================
  Files          192       192         —
  Lines        23324     23324         —
  Branches      8020      8020         —
==========================================
+ Hits         20969     20969         —
- Misses        2355      2355         —
- Partials      1327      1327         —

Generated by Codecov Action

alexander-alderman-webb mentioned this pull request May 18, 2026
Merged
alexander-alderman-webb marked this pull request as ready for review May 18, 2026 07:59
alexander-alderman-webb requested a review from a team as a code owner May 18, 2026 07:59
cursor Bot reviewed May 18, 2026
View reviewed changes

cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cursor Bugbot has reviewed your changes and found 2 potential issues.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d91d454. Configure here.

Comment thread tests/integrations/starlette/test_starlette.py Outdated
Comment thread tests/integrations/starlette/test_starlette.py
alexander-alderman-webb marked this pull request as draft May 18, 2026 08:02
alexander-alderman-webb marked this pull request as ready for review May 18, 2026 08:44
alexander-alderman-webb marked this pull request as draft May 18, 2026 08:47
alexander-alderman-webb marked this pull request as ready for review May 18, 2026 09:08
sentrivana approved these changes May 18, 2026
View reviewed changes

sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking great! So much better than unit testing the internal request extractor

alexander-alderman-webb mentioned this pull request May 19, 2026
Merged
alexander-alderman-webb changed the title test(starlette): Verify request info captured with POST endpoints test(starlette): Verify request info capture with POST endpoints Jun 9, 2026
alexander-alderman-webb merged commit 09ddd92 into master Jun 9, 2026
145 checks passed
alexander-alderman-webb deleted the webb/starlette/request-extractor-tests branch June 9, 2026 10:59
sentry-release-bot Bot mentioned this pull request Jun 16, 2026
Closed
6 tasks
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
test(starlette): Verify request info capture with POST endpoints (get…
5f643e4 
…sentry#6269)

Replace tests that directly call `StarletteRequestExtractor` methods with tests asserting request info is captured on error and transaction events for POST endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cursor[bot] cursor[bot] left review comments
sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL