fix(asgi): Gate query string and client IP behind send_default_pii by ericapisani · Pull Request #6501 · getsentry/sentry-python · GitHub

Move http.query and client.address attribute collection inside the
should_send_default_pii() check so sensitive values are not captured
by default.

Fixes PY-2514
Fixes #6499

Move http.query and client.address attribute collection inside the should_send_default_pii() check so sensitive values are not captured by default. Fixes PY-2514 Fixes #6499

PY-2514

bugbot run
@sentry review

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 666e6fb. Configure here.

Codecov Results 📊

✅ 89282 passed | ⏭️ 6013 skipped | Total: 95295 | Pass Rate: 93.69% | Execution Time: 301m 7s

📊 Comparison with Base Branch

Metric	Change
Total Tests	📈 +10
Passed Tests	📈 +10
Failed Tests	—
Skipped Tests	—

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2392 uncovered lines.
✅ Project coverage is 89.8%. Comparing base (base) to head (head).

Coverage diff

@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.80%    89.80%        —%
==========================================
  Files          192       192         —
  Lines        23453     23456        +3
  Branches      8060      8062        +2
==========================================
+ Hits         21061     21064        +3
- Misses        2392      2392         —
- Partials      1329      1329         —

Generated by Codecov Action

If Warden is right about url.full not actually being the full URL, we should probably fix that as well (append ? + the query part?).

url.full is the base URL path with no query string — _get_url() docstring says it builds the URL "without also including the querystring" — so gating it behind should_send_default_pii() silently drops the request URL from all ASGI traces when PII is disabled, breaking basic HTTP observability.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eb14dd0. Configure here.

Add span streaming support for the Quart integration when the trace_lifecycle stream experiment is enabled. Sets HTTP request attributes (method, headers, URL, query, client IP) on the segment span and uses the correct source constant from sentry_sdk.traces for span-first mode. Depends on #6501 being merged first. Fixes PY-2352 Fixes #6050

…etsentry#6501) Move http.query and client.address attribute collection inside the should_send_default_pii() check so sensitive values are not captured by default. Fixes PY-2514 Fixes getsentry#6499

…ry#6502) Add span streaming support for the Quart integration when the trace_lifecycle stream experiment is enabled. Sets HTTP request attributes (method, headers, URL, query, client IP) on the segment span and uses the correct source constant from sentry_sdk.traces for span-first mode. Depends on getsentry#6501 being merged first. Fixes PY-2352 Fixes getsentry#6050

fix(asgi): Gate query string and client IP behind send_default_pii

666e6fb

Move http.query and client.address attribute collection inside the should_send_default_pii() check so sensitive values are not captured by default. Fixes PY-2514 Fixes #6499

cursor Bot reviewed Jun 4, 2026

View reviewed changes

sentry Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/_asgi_common.py Outdated

sentry-warden Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/_asgi_common.py Outdated

fix

adc69e9

ericapisani marked this pull request as ready for review June 4, 2026 12:56

ericapisani requested a review from a team as a code owner June 4, 2026 12:56

sentry Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread tests/integrations/asgi/test_asgi.py

ericapisani mentioned this pull request Jun 4, 2026

feat(quart): Add span streaming support to Quart integration #6502

Merged

This comment was marked as spam.

Sign in to view

Update the value set on to include the query string

eb14dd0

cursor Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/_asgi_common.py Outdated

sentry Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread sentry_sdk/integrations/_asgi_common.py

ericapisani marked this pull request as draft June 10, 2026 15:02

.

a792df4

ericapisani marked this pull request as ready for review June 10, 2026 15:25

Merge branch 'master' into py-2514-gate-asgi-values-behind-pii

3e25e83

sentrivana approved these changes Jun 11, 2026

View reviewed changes

ericapisani merged commit f17dad9 into master Jun 11, 2026
271 of 273 checks passed

ericapisani deleted the py-2514-gate-asgi-values-behind-pii branch June 11, 2026 14:51

github-actions Bot mentioned this pull request Jun 15, 2026

[skill-drift] fix(sentry-python-sdk): document ASGI query string gating behind send_default_pii getsentry/sentry-for-ai#172

Merged

sentry-release-bot Bot mentioned this pull request Jun 16, 2026

publish: getsentry/sentry-python@2.63.0 getsentry/publish#8582

Closed

6 tasks

This was referenced Jun 25, 2026

fix(wsgi): Gate url.full, url.path, and http.query behind send_default_pii #6654

Merged

fix(aiohttp): Gate url.full, url.path, url.query on send_default_pii #6650

Merged

fix(asgi): Gate query string and client IP behind send_default_pii by ericapisani · Pull Request #6501 · getsentry/sentry-python · GitHub

Uh oh!

fix(asgi): Gate query string and client IP behind send_default_pii - #6501

fix(asgi): Gate query string and client IP behind send_default_pii#6501
ericapisani merged 5 commits into
masterfrom
py-2514-gate-asgi-values-behind-pii

ericapisani commented Jun 4, 2026

Uh oh!

linear-code Bot commented Jun 4, 2026

Uh oh!

ericapisani commented Jun 4, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

sentrivana commented Jun 8, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(asgi): Gate query string and client IP behind send_default_pii by ericapisani · Pull Request #6501 · getsentry/sentry-python · GitHub

Uh oh!

fix(asgi): Gate query string and client IP behind send_default_pii - #6501

fix(asgi): Gate query string and client IP behind send_default_pii#6501ericapisani merged 5 commits intomastergetsentry/sentry-python:masterfrom py-2514-gate-asgi-values-behind-piigetsentry/sentry-python:py-2514-gate-asgi-values-behind-piiCopy head branch name to clipboard

Conversation

ericapisani commented Jun 4, 2026

Uh oh!

linear-code Bot commented Jun 4, 2026

Uh oh!

ericapisani commented Jun 4, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Results 📊

📊 Comparison with Base Branch

Uh oh!

Uh oh!

sentrivana commented Jun 8, 2026

Uh oh!

This comment was marked as spam.

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(asgi): Gate query string and client IP behind send_default_pii#6501
ericapisani merged 5 commits into
masterfrom
py-2514-gate-asgi-values-behind-pii

github-actions Bot commented Jun 4, 2026 •
edited
Loading