FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(arq): Never capture control flow exceptions by alexander-alderman-webb · Pull Request #6507 · getsentry/sentry-python · GitHub

fix(arq): Never capture control flow exceptions - #6507

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/arq/control-flow-exceptions
Jun 5, 2026
Merged

fix(arq): Never capture control flow exceptions#6507
alexander-alderman-webb merged 1 commit into
masterfrom
webb/arq/control-flow-exceptions

Conversation

alexander-alderman-webb commented Jun 5, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Copy the early exit from the scope.transaction is not None branch.

Issues

Reminders

alexander-alderman-webb marked this pull request as ready for review June 5, 2026 08:10
alexander-alderman-webb requested a review from a team as a code owner June 5, 2026 08:10

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

88426 passed | ⏭️ 6022 skipped | Total: 94448 | Pass Rate: 93.62% | Execution Time: 293m 35s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 50.00%. Project has 2482 uncovered lines.
❌ Project coverage is 89.34%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/arq.py 50.00% ⚠️ 1 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    89.37%    89.34%    -0.03%
==========================================
  Files          192       192         —
  Lines        23285     23287        +2
  Branches      8002      8004        +2
==========================================
+ Hits         20811     20805        -6
- Misses        2474      2482        +8
- Partials      1309      1309         —

Generated by Codecov Action

alexander-alderman-webb merged commit baae950 into master Jun 5, 2026
144 checks passed
alexander-alderman-webb deleted the webb/arq/control-flow-exceptions branch June 5, 2026 13:04
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
Return early when `scope.transaction` is `None`, matching the existing behavior when there is a transaction on the scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL