fix: Remove 0000 trace_id fallbacks - #6570
Merged
sl0thentr0py merged 2 commits intoJun 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
sl0thentr0py
commented
Jun 15, 2026
Comment thread
sentry_sdk/scope.py
| has_tracing_enabled(self.get_client().options) | ||
| and self._span is not None | ||
| and not isinstance(self._span, NoOpStreamedSpan) | ||
| and not isinstance(self._span, (NoOpStreamedSpan, NoOpSpan)) |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
generalized these instance checks just in case
Sorry, something went wrong.
alexander-alderman-webb
approved these changes
Jun 15, 2026
Comment thread
sentry_sdk/scope.py
sl0thentr0py
force-pushed
the
neel/zero-trace-id
branch
from
3f15dc8 to
4a95f1c
Compare
June 15, 2026 14:15
Comment thread
sentry_sdk/_log_batcher.py
Outdated
sl0thentr0py
force-pushed
the
neel/zero-trace-id
branch
4 times, most recently
from
d668a2e to
0077f8b
Compare
June 15, 2026 15:51
Comment thread
sentry_sdk/scope.py
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 90848 passed | ⏭️ 6037 skipped | Total: 96885 | Pass Rate: 93.77% | Execution Time: 321m 27s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2420 uncovered lines.
@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.75% 89.76% +0.01%
==========================================
Files 192 192 —
Lines 23630 23636 +6
Branches 8134 8140 +6
==========================================
+ Hits 21208 21216 +8
- Misses 2422 2420 -2
- Partials 1341 1341 —Generated by Codecov Action |
Sorry, something went wrong.
When no span is active, span_id is now omitted from the envelope entirely rather than included as None. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
sl0thentr0py
force-pushed
the
neel/zero-trace-id
branch
from
fa34e28 to
3fb0a12
Compare
June 16, 2026 11:46
6 tasks
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
#### Issues * resolves: getsentry#6558 * resolves: PY-2526 --------- Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues