Review: #6579

Summary: Clean fix for ASGI URL duplication when scope["root_path"] is already included in scope["path"]. The approach is sound — thread a path_includes_root_path boolean through the URL construction pipeline.

✅ What works well

• Backward compatible — default is True, preserving existing behavior for frameworks that don't include root_path in path
• Framework-specific handling — correctly version-gated for Starlette (>=0.33), Quart (>=0.19), and hardcoded for Litestar/Starlite
• Test coverage — all 6 integrations tested (Django ASGI, FastAPI, Litestar, Quart, Starlette, Starlite), both span streaming and static lifecycle modes
• Clean threading — parameter flows through _get_url → _get_request_data → _get_request_attributes → _get_transaction_name_and_source → _get_segment_name_and_source

⚠️ Potential issues

1. Django ASGI test — The test sets comm.scope["root_path"] = "/root" but Django defaults to path_includes_root_path=True. Does Django ASGI actually include root_path in path? If not, this test might pass but produce incorrect URLs in production. Worth verifying Django's ASGI behavior.
2. No test for path_includes_root_path=False — The Starlette/FastAPI tests only exercise the True path (Starlette >= 0.33). The old behavior (False) has no dedicated test.
3. Edge case: empty path — When path_includes_root_path=True and scope["path"] is empty, the URL would be just scheme+host with no path. Unlikely but worth noting.

Verdict

Solid PR. The core logic is correct and well-structured. The main risk is the Django default assumption — worth double-checking before merging.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a96d284. Configure here.

url.path attribute always prepends root_path, ignoring path_includes_root_path

In _get_request_attributes() (_asgi_common.py ~line 152), attributes["url.path"] is always set to root_path + path regardless of path_includes_root_path. For frameworks where path_includes_root_path=True (e.g. Starlette >= 0.33), this re-introduces the exact duplication the PR is trying to fix, just for the url.path span attribute.

• _get_request_attributes accepts path_includes_root_path and correctly passes it to _get_url() for url.full.
• However, attributes["url.path"] = asgi_scope.get("root_path", "") + asgi_scope.get("path", "") at ~line 152 unconditionally concatenates root_path and path.
• When Starlette >= 0.33 sets path_includes_root_path=True (starlette.py line 148), scope["path"] already contains root_path, so this expression doubles the root path segment.
• _get_url() at line 45 correctly guards with if path_includes_root_path, showing the intended pattern was not applied consistently.

Identified by Warden code-review

No tests covering the new root_path_in_path behavior in any of the changed test files

The PR description states tests were added for root_path handling in each ASGI integration, but none of the changed test files (test_asgi.py, test_fastapi.py, test_starlette.py) contain any tests exercising root_path or the EITHER/EXCLUDED enum paths. Have you considered adding at least one test that sets root_path in the ASGI scope and asserts the resulting URL is not duplicated?

• grep -r 'root_path' tests/integrations/asgi/test_asgi.py returns no matches.
• grep -r 'root_path' tests/integrations/starlette/test_starlette.py returns no matches.
• grep -r 'root_path' tests/integrations/fastapi/test_fastapi.py returns no matches.
• The _RootPathInPath.EITHER branch in _get_path (used for Starlette >= 0.33) has detection logic (path.startswith(root_path + "/"), path == root_path) with no test coverage to verify correctness.
• The Starlette integration selects EITHER or EXCLUDED based on version at line 149–151 of starlette.py, but neither path has an integration-level test with root_path set.

Identified by Warden code-review