FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: Remove `brotli` from `requirements-testing.txt` by alexander-alderman-webb · Pull Request #6614 · getsentry/sentry-python · GitHub

ci: Remove brotli from requirements-testing.txt - #6614

Merged
alexander-alderman-webb merged 4 commits into
masterfrom
webb/requirements-testing/brotli
Jun 23, 2026
Merged

ci: Remove brotli from requirements-testing.txt#6614
alexander-alderman-webb merged 4 commits into
masterfrom
webb/requirements-testing/brotli

Conversation

alexander-alderman-webb commented Jun 22, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Remove the package from requirements-testing.txt and add the package as a dependency to only the test suites that rely on the package (if applicable).

This is part of environment cleanup before moving the remaining testing dependencies to a uv dependency group.

Issues

Reminders

github-actions Bot commented Jun 22, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

91388 passed | ⏭️ 6136 skipped | Total: 97524 | Pass Rate: 93.71% | Execution Time: 330m 42s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2410 uncovered lines.
✅ Project coverage is 89.86%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.85%    89.86%    +0.01%
==========================================
  Files          192       192         —
  Lines        23758     23758         —
  Branches      8204      8204         —
==========================================
+ Hits         21346     21348        +2
- Misses        2412      2410        -2
- Partials      1345      1345         —

Generated by Codecov Action

alexander-alderman-webb changed the title ci: Remove brotli from requirements-testing.txt ci: Remove brotli from requirements-testing.txt Jun 23, 2026
alexander-alderman-webb marked this pull request as ready for review June 23, 2026 09:15
alexander-alderman-webb requested a review from a team as a code owner June 23, 2026 09:15

ericapisani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

alexander-alderman-webb merged commit 37e3186 into master Jun 23, 2026
144 checks passed
alexander-alderman-webb deleted the webb/requirements-testing/brotli branch June 23, 2026 13:40
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
Remove the package from `requirements-testing.txt` and add it only as a dependency of the test suites that rely on it.
This is part of environment cleanup before moving the remaining testing dependencies to a uv dependency group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL