fix(tracing): Skip child span creation in streaming path when no current span (django) - #6809
Merged
ericapisani merged 2 commits intoJul 14, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ent span (django) When span streaming is enabled and there is no current span, Django integrations should not create new root segments for child-span operations. This adds a guard check using `sentry_sdk.traces.get_current_span()` before creating spans in the streaming path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 91200 passed | ⏭️ 6302 skipped | Total: 97502 | Pass Rate: 93.54% | Execution Time: 314m 16s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ❌ Patch coverage is 58.33%. Project has 2454 uncovered lines.
@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.77% 89.74% -0.03%
==========================================
Files 193 193 —
Lines 23898 23922 +24
Branches 8258 8282 +24
==========================================
+ Hits 21454 21468 +14
- Misses 2444 2454 +10
- Partials 1353 1363 +10Generated by Codecov Action |
Sorry, something went wrong.
The no-current-span guards in signal handlers now correctly prevent orphan root segments for GET requests (not in http_methods_to_capture), reducing the total span count and shifting the http.server span indices. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ericapisani
approved these changes
Jul 14, 2026
ericapisani
marked this pull request as ready for review
July 14, 2026 19:42
6 tasks
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
…ent span (django) (getsentry#6809) ## Summary - When span streaming is enabled and there is no current span, Django integrations should not create new root segments for child-span operations - Adds a `sentry_sdk.traces.get_current_span() is None` guard before creating spans in the streaming path - Affected: django init, asgi, caching, middleware, signals_handlers, tasks, templates, views Part of getsentry#6819 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #6819