fix(tracing): Skip child span creation in streaming path when no current span (misc) - #6815
Merged
ericapisani merged 2 commits intoJul 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ent span (misc) When span streaming is enabled and there is no current span, integrations should not create new root segments for child-span operations. This adds a guard check using `sentry_sdk.traces.get_current_span()` before creating spans in the streaming path. Affected integrations: socket, grpc (client), asyncio, mcp, rust_tracing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 91185 passed | ⏭️ 6302 skipped | Total: 97487 | Pass Rate: 93.54% | Execution Time: 304m 36s 📊 Comparison with Base Branch
All tests are passing successfully. ❌ Patch coverage is 74.42%. Project has 2444 uncovered lines.
@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.81% 89.78% -0.03%
==========================================
Files 193 193 —
Lines 23905 23921 +16
Branches 8262 8280 +18
==========================================
+ Hits 21471 21477 +6
- Misses 2434 2444 +10
- Partials 1351 1360 +9Generated by Codecov Action |
Sorry, something went wrong.
Align the rust_tracing and grpc aio streaming tests with the new behavior where no root segment is created when there is no active span in the streaming path.
ericapisani
approved these changes
Jul 15, 2026
ericapisani
marked this pull request as ready for review
July 15, 2026 17:15
6 tasks
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code