fix: Include query string and fragment in url.full span attribute - #6861
Merged
sentrivana merged 5 commits intoJul 23, 2026
Merged
fix: Include query string and fragment in url.full span attribute#6861sentrivana merged 5 commits into
sentrivana merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The `url.full` attribute was only being set to the base URL (scheme + host + path), omitting query string and fragment. This affected aiohttp (server and client), httpx, httpx2, and WSGI integrations. ASGI and Quart were already correct. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 95314 passed | ❌ 1 failed | ⏭️ 6340 skipped | Total: 101655 | Pass Rate: 93.76% | Execution Time: 329m 27s 📊 Comparison with Base Branch
➕ New Tests (1)View new tests
❌ Failed Teststest_circular_references_span_streamingFile: tests.tracing.test_misc tests/tracing/test_misc.py:379: in test_circular_references_span_streaming
assert gc.collect() == 0
E assert 10 == 0
E + where 10 = <built-in function collect>()
E + where <built-in function collect> = gc.collect
✅ Patch coverage is 93.48%. Project has 2508 uncovered lines.
@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.68% 89.69% +0.01%
==========================================
Files 193 193 —
Lines 24285 24320 +35
Branches 8550 8570 +20
==========================================
+ Hits 21779 21812 +33
- Misses 2506 2508 +2
- Partials 1393 1393 —Generated by Codecov Action |
Sorry, something went wrong.
…y/fragment Resolved merge conflict in the client streaming path to combine query/fragment appending with the data_collection gate. Fixed a bug in the server-side should_send_default_pii path where url_full was referenced before assignment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sentrivana
marked this pull request as ready for review
July 23, 2026 08:38
alexander-alderman-webb
approved these changes
Jul 23, 2026
alexander-alderman-webb
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
…etsentry#6861) The `url.full` span attribute was only being set to the base URL (scheme + host + path), omitting query string and fragment. Closes getsentry#6860 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The url.full span attribute was only being set to the base URL (scheme + host + path), omitting query string and fragment.
Closes #6860