fix(tests): Remove redundant type filters after capture_items with args - #6867
Merged
sentrivana merged 2 commits intoJul 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…tems calls capture_items already filters by type at capture time, so the subsequent `if item.type == "xxx"` in list comprehensions was redundant. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 95315 passed | ⏭️ 6340 skipped | Total: 101655 | Pass Rate: 93.76% | Execution Time: 336m 8s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2508 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.65% 89.69% +0.04%
==========================================
Files 193 193 —
Lines 24324 24324 —
Branches 8572 8572 —
==========================================
+ Hits 21807 21816 +9
- Misses 2517 2508 -9
- Partials 1395 1393 -2Generated by Codecov Action |
Sorry, something went wrong.
sentrivana
marked this pull request as ready for review
July 23, 2026 14:39
alexander-alderman-webb
approved these changes
Jul 27, 2026
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
…args (getsentry#6867) `capture_items` already filters by type if provided as arg(s), so the subsequent `if item.type == "xxx"` in list comprehensions was redundant. --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capture_items already filters by type if provided as arg(s), so the subsequent if item.type == "xxx" in list comprehensions was redundant.