| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
…s Api Read `effort` field from the `reasoning`request parameter from `responses.create()` and set it on the gen_ai span as `gen_ai.request.reasoning_level`. `reasoning`may be passed as a dict or as the SDK's `Reasoning`object. Refs #6878 Refs PY-2621
…ons Api Read `reasoning_effort` request parameter from `chat.completions.create()` and set it on the gen_ai span as `gen_ai.request.reasoning_level`. Refs #6877 Refs PY-2620
Codecov Results 📊✅ 98651 passed | ⏭️ 6806 skipped | Total: 105457 | Pass Rate: 93.55% | Execution Time: 360m 11s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2508 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.69% 89.72% +0.03%
==========================================
Files 193 193 —
Lines 24437 24402 -35
Branches 8660 8648 -12
==========================================
+ Hits 21919 21894 -25
- Misses 2518 2508 -10
- Partials 1398 1400 +2Generated by Codecov Action |
Sorry, something went wrong.
There was a problem hiding this comment.
Can you also co-locate assertions with assertions on other request configuration such asgen_ai.request.top_p, gen_ai.request.temperature, etc ...
That way, we ensure that the attribute is set in all scenarios we test against, such as streaming and non-streaming, sync and async, etc ...
Sorry, something went wrong.
Only extract `effort` from dict `reasoning` in the Responses API. Refs #6878
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a509b01. Configure here.
Sorry, something went wrong.
There was a problem hiding this comment.
Nice, LGTM!
Sorry, something went wrong.
|
As discussed in person, adding the assertions to existing tests is ugly because it's not available on old openai versions. Feel free to go with your original approach with adding a few new tests @pabloDeputter! |
Sorry, something went wrong.
…rom Completions API
|
You can merge whenever you've passed CI since I've approved the PR already. |
Sorry, something went wrong.
…etsentry#6892) ### Description Add `gen_ai.request.reasoning.level` to OpenAI spans for: - Responses API via `reasoning.effort` - Chat Completions API via `reasoning_effort` #### Issues Refs: getsentry#6877 & getsentry#6878; PY-2620 & PY-2621
| Back | FazBrowse Home | New Git URL |
Description
Add gen_ai.request.reasoning.level to OpenAI spans for:
Issues
Refs: #6877 & #6878; PY-2620 & PY-2621
Reminders