ref(mcp): Remove redundant mcp.tool.result.is_error - #6915
Merged
alexander-alderman-webb merged 30 commits intoJul 29, 2026
Merged
ref(mcp): Remove redundant mcp.tool.result.is_error#6915alexander-alderman-webb merged 30 commits into
alexander-alderman-webb merged 30 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 98542 passed | ⏭️ 6772 skipped | Total: 105314 | Pass Rate: 93.57% | Execution Time: 355m 23s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2499 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.84% 89.84% —%
==========================================
Files 193 193 —
Lines 24588 24587 -1
Branches 8744 8744 —
==========================================
+ Hits 22089 22088 -1
- Misses 2499 2499 —
- Partials 1400 1400 —Generated by Codecov Action |
Sorry, something went wrong.
alexander-alderman-webb
marked this pull request as ready for review
July 29, 2026 12:26
sentrivana
approved these changes
Jul 29, 2026
Comment thread
sentry_sdk/integrations/mcp.py
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
The attribute is redundant with the captured exception, and the span status already indicates if an exception bubbled out of the span context manager.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The attribute is redundant with the captured exception, and is deprecated anyway.
Issues
Reminders