FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test(fastmcp): Replace broad `try...except` with `skipif` by alexander-alderman-webb · Pull Request #6922 · getsentry/sentry-python · GitHub

/ sentry-python Public

test(fastmcp): Replace broad try...except with skipif - #6922

Merged
alexander-alderman-webb merged 4 commits into
masterfrom
webb/fastmcp-try-except
Jul 29, 2026
ConversationCommits (4)ChecksFiles changed
Merged

test(fastmcp): Replace broad try...except with skipif#6922
alexander-alderman-webb merged 4 commits into
masterfrom
webb/fastmcp-try-except

Conversation

alexander-alderman-webb commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

Broad try...except blocks can mask other problems and makes the test hard to maintain.

Issues

Reminders

github-actions Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 98542 passed | ⏭️ 6772 skipped | Total: 105314 | Pass Rate: 93.57% | Execution Time: 352m 58s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests 📉 -16
Failed Tests —
Skipped Tests 📈 +16

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2499 uncovered lines.
✅ Project coverage is 89.84%. Comparing base (base) to head (head).

Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.84%    89.84%        —%
==========================================
  Files          193       193         —
  Lines        24588     24588         —
  Branches      8744      8744         —
==========================================
+ Hits         22089     22089         —
- Misses        2499      2499         —
- Partials      1400      1400         —

Generated by Codecov Action

alexander-alderman-webb marked this pull request as ready for review July 29, 2026 12:26
alexander-alderman-webb requested a review from a team as a code owner July 29, 2026 12:26
cursor Bot reviewed Jul 29, 2026
View reviewed changes

cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cursor Bugbot has reviewed your changes and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eb76bfa. Configure here.

Comment thread tests/integrations/fastmcp/test_fastmcp.py
sentry Bot reviewed Jul 29, 2026
View reviewed changes
Comment thread tests/integrations/fastmcp/test_fastmcp.py
alexander-alderman-webb merged commit 8393b88 into master Jul 29, 2026
145 checks passed
alexander-alderman-webb deleted the webb/fastmcp-try-except branch July 29, 2026 13:05
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
test(fastmcp): Replace broad try...except with skipif (getsentry#…
bff3aa5 
…6922)
sentry-release-bot Bot mentioned this pull request Aug 10, 2026
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sentry[bot] sentry[bot] left review comments
cursor[bot] cursor[bot] left review comments
sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL