feat(openai-agents): Set the gen_ai.tool.definitions attribute - #6956
Merged
alexander-alderman-webb merged 52 commits intoJul 31, 2026
Merged
feat(openai-agents): Set the gen_ai.tool.definitions attribute#6956alexander-alderman-webb merged 52 commits into
alexander-alderman-webb merged 52 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ebb/openai-responses-gen-ai-tool-definitions
…ebb/openai-responses-gen-ai-tool-definitions
…b/openai-agents-tool-definitions
…gents-agent-tool-definitions
…enai-agents-tool-definitions-2
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 100310 passed | ⏭️ 7021 skipped | Total: 107331 | Pass Rate: 93.46% | Execution Time: 360m 34s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 94.20%. Project has 2511 uncovered lines.
@@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.92% 89.89% -0.03%
==========================================
Files 193 193 —
Lines 24766 24832 +66
Branches 8884 8912 +28
==========================================
+ Hits 22268 22321 +53
- Misses 2498 2511 +13
- Partials 1416 1415 -1Generated by Codecov Action |
Sorry, something went wrong.
Comment thread
sentry_sdk/integrations/openai_agents/spans/ai_client.py
Outdated
Comment thread
sentry_sdk/integrations/openai_agents/spans/ai_client.py
alexander-alderman-webb
marked this pull request as ready for review
July 31, 2026 08:56
Comment thread
sentry_sdk/integrations/openai_agents/spans/ai_client.py
Comment thread
sentry_sdk/integrations/openai_agents/spans/ai_client.py
…ebb/openai-responses-gen-ai-tool-definitions
…b/openai-agents-tool-definitions
…gents-agent-tool-definitions
…enai-agents-tool-overwrite
Comment thread
tests/integrations/openai_agents/test_openai_agents.py
sentrivana
approved these changes
Jul 31, 2026
…enai-agents-tool-overwrite
…nts-tool-definitions-2
Copy link
Copy Markdown
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 114f34c. Configure here.
Sorry, something went wrong.
Comment thread
sentry_sdk/integrations/openai_agents/spans/ai_client.py
alexander-alderman-webb
deleted the
webb/openai-agents-tool-definitions-2
branch
July 31, 2026 13:07
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
…sentry#6956) Set the attribute with `type`, `name` and `description` fields for function and custom tools, and additionally the `parameters` field for function tools. Only the `type` and `name` fields are recorded for instances of other tool types.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Set the attribute according to the schema defined in
https://github.com/getsentry/rfcs/blob/main/text/0153-decoupling-sentrys-generative-ai-conventions-from-open-telemetry.md
Unlike openai, the package uses dataclasses for tool types. Handle each one individually.
Issues
Closes #5767
Closes #6900
Reminders