fix(openai-agents): Stop destructively wrapping tools - #6961
fix(openai-agents): Stop destructively wrapping tools#6961alexander-alderman-webb merged 38 commits into
Conversation
Sorry, something went wrong.
…ebb/openai-responses-gen-ai-tool-definitions
…ebb/openai-responses-gen-ai-tool-definitions
…b/openai-agents-tool-definitions
…gents-agent-tool-definitions
…enai-agents-tool-overwrite
Codecov Results 📊✅ 99634 passed | ⏭️ 6757 skipped | Total: 106391 | Pass Rate: 93.65% | Execution Time: 354m 50s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2505 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.89% 89.88% -0.01%
==========================================
Files 193 193 —
Lines 24750 24750 —
Branches 8858 8858 —
==========================================
+ Hits 22247 22245 -2
- Misses 2503 2505 +2
- Partials 1414 1414 —Generated by Codecov Action |
Sorry, something went wrong.
…b/openai-agents-tool-definitions
…gents-agent-tool-definitions
…enai-agents-tool-overwrite
This reverts commit 4efb6fb.
…ebb/openai-responses-gen-ai-tool-definitions
…b/openai-agents-tool-definitions
…gents-agent-tool-definitions
…enai-agents-tool-overwrite
sentrivana
left a comment
There was a problem hiding this comment.
lgtm, but check out the bot comments if you haven't yet in case there's something to them
Sorry, something went wrong.
…enai-agents-tool-overwrite
|
I've just removed the idempotency guard since there's none currently in place with wrapping either. |
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7f5cc96. Configure here.
Sorry, something went wrong.
Description
Overwrite the on_invoke_tool property instead of wrapping the entire tool.
Otherwise, the follow-up PR has the test error
FAILED tests/integrations/openai_agents/test_openai_agents.py::test_tool_definitions[True-True] - agents.exceptions.UserError: ToolSearchTool() requires at least one searchable Responses surface: a tool_namespace(...) function tool, a deferred-loading function tool (`function_tool(..., defer_loading=True)`), or a deferred-loading hosted MCP server (`HostedMCPTool(tool_config={..., 'defer_loading': True})`).as defer_loading is not forwarded in the wrapper.
Issues
Reminders