ref(tests): Replace _transport_works_cases loop with explicit case list - #6978
Merged
ericapisani merged 1 commit intoJul 31, 2026
Merged
ref(tests): Replace _transport_works_cases loop with explicit case list#6978ericapisani merged 1 commit into
ericapisani merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Write out the parametrized cases for test_transport_works as literal tuples instead of generating them with nested loops, keeping the PY37/PY38-dependent variants as three explicit lists Refs PY-2641
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 94982 passed | ⏭️ 6343 skipped | Total: 101325 | Pass Rate: 93.74% | Execution Time: 342m 4s 📊 Comparison with Base Branch
➖ Removed Tests (1)View removed tests
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2511 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.91% 89.89% -0.02%
==========================================
Files 193 193 —
Lines 24832 24832 —
Branches 8912 8912 —
==========================================
+ Hits 22326 22321 -5
- Misses 2506 2511 +5
- Partials 1417 1414 -3Generated by Codecov Action |
Sorry, something went wrong.
sl0thentr0py
approved these changes
Jul 31, 2026
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
…st (getsentry#6978) Write out the parametrized cases for test_transport_works as literal tuples instead of generating them with nested loops, keeping the PY37/PY38-dependent variants as three explicit lists Refs PY-2641
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write out the parametrized cases for test_transport_works as literal tuples instead of generating them with nested loops, keeping the PY37/PY38-dependent variants as three explicit lists
Refs PY-2641