FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ci: Add `pydantic-ai-slim` to uv typing group by alexander-alderman-webb · Pull Request #7025 · getsentry/sentry-python · GitHub

/ sentry-python Public

ci: Add pydantic-ai-slim to uv typing group - #7025

Merged
alexander-alderman-webb merged 5 commits into
masterfrom
webb/pydantic-ai-mypy
Aug 5, 2026
ConversationCommits (5)ChecksFiles changed
Merged

ci: Add pydantic-ai-slim to uv typing group#7025
alexander-alderman-webb merged 5 commits into
masterfrom
webb/pydantic-ai-mypy

Conversation

alexander-alderman-webb commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add package to the group and fix typing problems.

sentry_sdk/integrations/pydantic_ai/spans/utils.py:15: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py:33: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py:35: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py:35: error: Incompatible types in assignment (expression has type "None", variable has type "type[BinaryContent]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py:36: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py:36: error: Incompatible types in assignment (expression has type "None", variable has type "type[ImageUrl]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py:126: error: Function "ImageUrl" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py:128: error: Function "BinaryContent" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:37: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:54: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:54: error: Incompatible types in assignment (expression has type "None", variable has type "type[BaseToolCallPart]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:55: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:55: error: Incompatible types in assignment (expression has type "None", variable has type "type[BaseToolReturnPart]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:56: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:56: error: Incompatible types in assignment (expression has type "None", variable has type "type[SystemPromptPart]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:57: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:57: error: Incompatible types in assignment (expression has type "None", variable has type "type[UserPromptPart]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:58: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:58: error: Incompatible types in assignment (expression has type "None", variable has type "type[TextPart]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:59: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:59: error: Incompatible types in assignment (expression has type "None", variable has type "type[ThinkingPart]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:60: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:60: error: Incompatible types in assignment (expression has type "None", variable has type "type[BinaryContent]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:61: error: Cannot assign to a type  [misc]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:61: error: Incompatible types in assignment (expression has type "None", variable has type "type[ImageUrl]")  [assignment]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:96: error: Function "SystemPromptPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:144: error: Function "SystemPromptPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:147: error: Function "TextPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:148: error: Function "ThinkingPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:149: error: Function "BaseToolCallPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:152: error: Function "BaseToolReturnPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:160: error: Function "BaseToolCallPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:169: error: Function "BaseToolReturnPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:182: error: Function "ImageUrl" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:184: error: Function "BinaryContent" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:240: error: Function "TextPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py:242: error: Function "BaseToolCallPart" could always be true in boolean context  [truthy-function]
sentry_sdk/integrations/pydantic_ai/patches/tools.py:17: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/patches/tools.py:21: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/patches/tools.py:98: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/pydantic_ai/patches/tools.py:113: error: "type[ToolManager[AgentDepsT]]" has no attribute "_call_tool"  [attr-defined]
sentry_sdk/integrations/pydantic_ai/patches/tools.py:177: error: "type[ToolManager[AgentDepsT]]" has no attribute "_call_tool"  [attr-defined]
sentry_sdk/integrations/pydantic_ai/patches/graph_nodes.py:12: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/patches/graph_nodes.py:73: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/pydantic_ai/patches/graph_nodes.py:106: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/pydantic_ai/patches/agent_run.py:13: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/patches/agent_run.py:195: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/pydantic_ai/patches/agent_run.py:198: error: Cannot assign to a method  [method-assign]
sentry_sdk/integrations/pydantic_ai/__init__.py:7: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/__init__.py:27: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/__init__.py:28: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/__init__.py:36: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/__init__.py:56: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/__init__.py:76: error: Unused "type: ignore" comment  [unused-ignore]
sentry_sdk/integrations/pydantic_ai/__init__.py:111: error: Cannot assign to a method  [method-assign]

Issues

Closes #7018

Reminders

sentry-warden Bot reviewed Aug 4, 2026
View reviewed changes
Comment thread uv.lock

github-actions Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 96974 passed | ⏭️ 6239 skipped | Total: 103213 | Pass Rate: 93.96% | Execution Time: 346m 18s

📊 Comparison with Base Branch

Metric Change
Total Tests —
Passed Tests —
Failed Tests —
Skipped Tests —

✨ No test changes detected

All tests are passing successfully.

❌ Patch coverage is 73.68%. Project has 2497 uncovered lines.
✅ Project coverage is 89.94%. Comparing base (base) to head (head).

Files with missing lines (2)
File Patch % Lines
sentry_sdk/integrations/pydantic_ai/spans/ai_client.py 52.94% ⚠️ 8 Missing
sentry_sdk/integrations/pydantic_ai/spans/invoke_agent.py 60.00% ⚠️ 2 Missing and 1 partials
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.90%    89.94%    +0.04%
==========================================
  Files          193       193         —
  Lines        24828     24828         —
  Branches      8930      8930         —
==========================================
+ Hits         22322     22331        +9
- Misses        2506      2497        -9
- Partials      1416      1414        -2

Generated by Codecov Action

alexander-alderman-webb marked this pull request as ready for review August 4, 2026 07:29
alexander-alderman-webb requested a review from a team as a code owner August 4, 2026 07:29
alexander-alderman-webb merged commit 152b088 into master Aug 5, 2026
145 checks passed
alexander-alderman-webb deleted the webb/pydantic-ai-mypy branch August 5, 2026 12:24
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
ci: Add pydantic-ai-slim to uv typing group (getsentry#7025)
8c8b302 
Add `pydantic-ai-slim` to the typing dependency group and fix the resulting mypy errors.
sentry-release-bot Bot mentioned this pull request Aug 10, 2026
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sentry-warden[bot] sentry-warden[bot] left review comments
sentrivana sentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add pydantic-ai to typing group

2 participants

Back | FazBrowse Home | New Git URL