FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test(arq): Avoid race between the exception and transaction events by alexander-alderman-webb · Pull Request #7052 · getsentry/sentry-python · GitHub

test(arq): Avoid race between the exception and transaction events - #7052

Merged
alexander-alderman-webb merged 3 commits into
masterfrom
webb/arq/flaky-concurrency-test
Aug 6, 2026
Merged

test(arq): Avoid race between the exception and transaction events#7052
alexander-alderman-webb merged 3 commits into
masterfrom
webb/arq/flaky-concurrency-test

Conversation

Copy link
Copy Markdown
Contributor

Description

The failure

=================================== FAILURES ===================================
_________________________ test_job_concurrency[False] __________________________
tests/integrations/arq/test_arq.py:746: in test_job_concurrency
    assert exception_event["exception"]["values"][0]["type"] == "ZeroDivisionError"
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E   KeyError: 'exception'

indicates that we're capturing a transaction before an error object. Filter for the error to eliminate the flake.

Issues

Reminders

alexander-alderman-webb requested a review from a team as a code owner August 5, 2026 15:54

cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cursor Bugbot has reviewed your changes and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bdfe828. Configure here.

Comment thread tests/integrations/arq/test_arq.py Outdated
Comment thread tests/integrations/arq/test_arq.py Outdated

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

98904 passed | ⏭️ 6479 skipped | Total: 105383 | Pass Rate: 93.85% | Execution Time: 356m 17s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📈 +1
Failed Tests 📉 -1
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[experiment-thread]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2498 uncovered lines.
✅ Project coverage is 89.95%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.92%    89.95%    +0.03%
==========================================
  Files          193       193         —
  Lines        24859     24859         —
  Branches      8962      8962         —
==========================================
+ Hits         22354     22361        +7
- Misses        2505      2498        -7
- Partials      1414      1414         —

Generated by Codecov Action

alexander-alderman-webb changed the title test(arq): Avoid race between error and transaction test(arq): Avoid race between the exception and transaction events Aug 6, 2026
alexander-alderman-webb merged commit 0c40ed2 into master Aug 6, 2026
145 checks passed
alexander-alderman-webb deleted the webb/arq/flaky-concurrency-test branch August 6, 2026 06:39
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
…etsentry#7052)

The `exception_event` could be a transaction if the transaction arrived at the transport layer first, which resulted in a `KeyError`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL