FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ref(langchain): Remove `on_agent_finish()` hook by alexander-alderman-webb · Pull Request #7059 · getsentry/sentry-python · GitHub

ref(langchain): Remove on_agent_finish() hook - #7059

Merged
alexander-alderman-webb merged 1 commit into
masterfrom
webb/remove-on-agent-end-hook
Aug 6, 2026
Merged

ref(langchain): Remove on_agent_finish() hook#7059
alexander-alderman-webb merged 1 commit into
masterfrom
webb/remove-on-agent-end-hook

Conversation

Copy link
Copy Markdown
Contributor

Description

There is no hook that stores a span corresponding to the run_id.

Issues

Reminders

alexander-alderman-webb marked this pull request as ready for review August 6, 2026 09:32
alexander-alderman-webb requested a review from a team as a code owner August 6, 2026 09:32

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

99162 passed | ⏭️ 6479 skipped | Total: 105641 | Pass Rate: 93.87% | Execution Time: 357m 51s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests 📈 +1
Failed Tests 📉 -1
Skipped Tests

➖ Removed Tests (1)

View removed tests
  • test_continuous_profiler_auto_start_and_stop_sampled[experiment-gevent]
    • File: tests.profiler.test_continuous_profiler

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2502 uncovered lines.
✅ Project coverage is 89.97%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.95%    89.97%    +0.02%
==========================================
  Files          193       193         —
  Lines        24955     24946        -9
  Branches      9004      9000        -4
==========================================
+ Hits         22448     22444        -4
- Misses        2507      2502        -5
- Partials      1437      1435        -2

Generated by Codecov Action

alexander-alderman-webb merged commit 06f3264 into master Aug 6, 2026
143 of 145 checks passed
alexander-alderman-webb deleted the webb/remove-on-agent-end-hook branch August 6, 2026 11:04
mgaligniana pushed a commit to mgaligniana/sentry-python that referenced this pull request Aug 9, 2026
There is no hook that stores a span corresponding to the `run_id` passed to the hook.
The cleanup in the hook therefore never ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL