chore(huggingface-hub): Fix chat completion stream type - #7070
Merged
alexander-alderman-webb merged 7 commits intoAug 7, 2026
Merged
chore(huggingface-hub): Fix chat completion stream type#7070alexander-alderman-webb merged 7 commits into
alexander-alderman-webb merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
alexander-alderman-webb
marked this pull request as ready for review
August 6, 2026 15:07
alexander-alderman-webb
changed the base branch from
renovate/lock-file-maintenance
to
master
August 6, 2026 15:11
Copy link
Copy Markdown
Contributor
Codecov Results 📊✅ 96974 passed | ⏭️ 6239 skipped | Total: 103213 | Pass Rate: 93.96% | Execution Time: 346m 55s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2506 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
- Coverage 89.95% 89.91% -0.04%
==========================================
Files 193 193 —
Lines 24946 24828 -118
Branches 9000 8930 -70
==========================================
+ Hits 22439 22322 -117
- Misses 2507 2506 -1
- Partials 1435 1416 -19Generated by Codecov Action |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks like there's some test failures, will wait until they're 🟢 before taking a look |
Sorry, something went wrong.
sentrivana
approved these changes
Aug 7, 2026
mgaligniana
pushed a commit
to mgaligniana/sentry-python
that referenced
this pull request
Aug 9, 2026
Add `huggingface-hub` to the typing dependency group and fix resulting mypy errors.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add huggingface-hub to the uv typing group.
Cast iterator to the correct type.
The type for chat_completion() can be found here:
https://github.com/huggingface/huggingface_hub/blob/b4f4e92226642a4472945a174b9761b688a27dae/src/huggingface_hub/inference/_client.py#L559
Issues
Reminders