FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: Set the segment name on the scope with `NoOpStreamedSpan` by alexander-alderman-webb · Pull Request #7162 · getsentry/sentry-python · GitHub

/ sentry-python Public

feat: Set the segment name on the scope with NoOpStreamedSpan - #7162

Merged
alexander-alderman-webb merged 9 commits into
masterfrom
webb/set-transaction-on-scope
Aug 12, 2026
ConversationCommits (9)ChecksFiles changed
Merged

feat: Set the segment name on the scope with NoOpStreamedSpan#7162
alexander-alderman-webb merged 9 commits into
masterfrom
webb/set-transaction-on-scope

Conversation

alexander-alderman-webb commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Add the name parameter to NoOpStreamedSpan.__init__().

Set the transaction name on the scope when a segment NoOpStreamedSpan is set on the scope.

The commit 11c1e90 removed validation of tracing without performance, so I've added a new test where tracing is disabled.

Issues

Reminders

alexander-alderman-webb changed the title feat: Set segment name on scope when span is NoOpStreamedSpan feat: Set segment name on scope forNoOpStreamedSpan Aug 11, 2026

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 104113 passed | ⏭️ 6677 skipped | Total: 110790 | Pass Rate: 93.97% | Execution Time: 362m 27s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +129
Passed Tests 📈 +129
Failed Tests —
Skipped Tests —

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2485 uncovered lines.
❌ Project coverage is 90.12%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/scope.py 100.00% ⚠️ 1 partials
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
- Coverage    90.15%    90.12%    -0.03%
==========================================
  Files          193       193         —
  Lines        25147     25153        +6
  Branches      9136      9140        +4
==========================================
+ Hits         22669     22668        -1
- Misses        2478      2485        +7
- Partials      1431      1431         —

Generated by Codecov Action

alexander-alderman-webb marked this pull request as ready for review August 11, 2026 11:10
alexander-alderman-webb requested a review from a team as a code owner August 11, 2026 11:10
cursor Bot reviewed Aug 11, 2026
View reviewed changes

cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Cursor Bugbot has reviewed your changes and found 1 potential issue.

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 63e764a. Configure here.

Comment thread sentry_sdk/scope.py
sentry Bot reviewed Aug 11, 2026
View reviewed changes
Comment thread sentry_sdk/scope.py Outdated
sentrivana approved these changes Aug 11, 2026
View reviewed changes

sentrivana left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, just one question.

Comment thread sentry_sdk/traces.py Outdated

class NoOpStreamedSpan(StreamedSpan):
__slots__ = (
"_noop_name",

sentrivana Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I assume we can't use the existing _name slot for this?

alexander-alderman-webb Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The parent _name is typed as str, and all the __init__ parameters are optional for NoOpStreamedSpan.

sentrivana Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't we do something similar for scope though? In the parent class it's not optional, but in NoOpStreamedSpan it is, and it uses the same slot.

I guess that's what the # type: ignore[assignment] is there for. TBH I'd prefer we do the same with _name to keep stuff consistent.

alexander-alderman-webb Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't mind, fair to follow the existing pattern: f4986d9

alexander-alderman-webb changed the title feat: Set segment name on scope forNoOpStreamedSpan feat: Set segment name on scope for NoOpStreamedSpan Aug 12, 2026
alexander-alderman-webb changed the title feat: Set segment name on scope for NoOpStreamedSpan feat: Set the segment name on the scope with NoOpStreamedSpan Aug 12, 2026
alexander-alderman-webb merged commit 264addc into master Aug 12, 2026
145 checks passed
alexander-alderman-webb deleted the webb/set-transaction-on-scope branch August 12, 2026 08:31
sentry-release-bot Bot mentioned this pull request Aug 13, 2026
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sentry[bot] sentry[bot] left review comments
sentrivana sentrivana approved these changes
cursor[bot] cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL