chore: Drop enable_logs, enable_metrics options in new major - #7178
Conversation
Sorry, something went wrong.
Codecov Results 📊✅ 110340 passed | ❌ 2 failed | ⏭️ 5428 skipped | Total: 115770 | Pass Rate: 95.31% | Execution Time: 385m 1s 📊 Comparison with Base Branch
➕ New Tests (2)View new tests
❌ Failed Teststest_url_query_data_collection_span_streaming[send_default_pii_true]File: tests.integrations.sanic.test_sanic tests/integrations/sanic/test_sanic.py:730: in test_url_query_data_collection_span_streaming
with c as client:
/usr/lib/python3.10/contextlib.py:135: in __enter__
return next(self.gen)
tests/integrations/sanic/test_sanic.py:93: in reusable_client
client.__enter__()
.tox/py3.10-sanic-v23.12.2/lib/python3.10/site-packages/sanic_testing/reusable.py:65: in __enter__
self.run()
.tox/py3.10-sanic-v23.12.2/lib/python3.10/site-packages/sanic_testing/reusable.py:77: in run
self._server = self._run(self._server_co)
.tox/py3.10-sanic-v23.12.2/lib/python3.10/site-packages/sanic_testing/reusable.py:198: in _run
return self._loop.run_until_complete(coro)
/usr/lib/python3.10/asyncio/base_events.py:649: in run_until_complete
return future.result()
.tox/py3.10-sanic-v23.12.2/lib/python3.10/site-packages/sanic/mixins/startup.py:612: in create_server
return await serve(
.tox/py3.10-sanic-v23.12.2/lib/python3.10/site-packages/sanic/server/async_server.py:113: in __await__
self.server = task.result()
/usr/lib/python3.10/asyncio/base_events.py:1519: in create_server
raise OSError(err.errno, 'error while attempting '
E OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 34821): address already in use
test_cache_spans_decorator[True]File: tests.integrations.django.test_cache_module tests/integrations/django/test_cache_module.py:380: in test_cache_spans_decorator
assert not spans[0]["attributes"]["cache.hit"]
E assert not True
✅ Patch coverage is 100.00%. Project has 2275 uncovered lines. @@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 89.93% 90.49% +0.56%
==========================================
Files 193 185 -8
Lines 24908 23910 -998
Branches 8986 8808 -178
==========================================
+ Hits 22398 21635 -763
- Misses 2510 2275 -235
- Partials 1430 1378 -52Generated by Codecov Action |
Sorry, something went wrong.
ericapisani
left a comment
There was a problem hiding this comment.
Other than the one note for our guidance in the migration guide, this LGTM
Sorry, something went wrong.
| - Removed the RedisIntegration `max_data_size` option. | ||
| - Removed the possibility to supply a specific client to the LaunchDarklyIntegration. | ||
| - The `enable_tracing` option was removed. Use `traces_sample_rate=1.0` instead. | ||
| - The `enable_logs` option was removed. Using Sentry's logging API now works without requiring setting `enable_logs=True`. Automatic capture of logs emitted by the `logging` standard library module or Loguru can be turned on by providing the `capture_sentry_logs=True` option to either `LoggingIntegration` or `LoguruIntegration`: |
There was a problem hiding this comment.
Automatic capture of logs emitted by the logging standard library module or Loguru can be turned on by providing the capture_sentry_logs=True option to either LoggingIntegration or LoguruIntegration
GivenLoggingIntegration and LoguruIntegration are both auto-enabling integrations, I wonder if it might be more useful to give an example for opting out rather than opting in.
Sorry, something went wrong.
There was a problem hiding this comment.
They're auto-enabling for errors, but they won't start capturing logs unless you explicitly opt in. So no logs is default behavior, and if you want logs, you need to explicitly enable that.
Sorry, something went wrong.
There was a problem hiding this comment.
Also, status update 🤦🏻♀️ but this will change in a later PR. Will leave this as is as it captures the current state and will update it in the follow up PR.
Sorry, something went wrong.
The options were deprecated with 2fef9bc.